Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data source no-code module #1242

Closed
wants to merge 7 commits into from
Closed

Conversation

catsby
Copy link
Contributor

@catsby catsby commented Feb 2, 2024

Description

This PR adds a new data source tfe_no_code_module for getting basic info on a single no-code module.

Remember to:

Testing plan

  1. Have an existing no-code provisioning module
  2. Get it's ID (either with the API or visiting the no-code module's settings on app.terraform.io)
  3. Use the ID in the data sources' ID field
  4. Enjoy?

External links

API Docs:

Output from acceptance tests

$ ENABLE_BETA=1 TESTARGS="-run=TestAccTFENoCodeModuleDataSource_public -v" make testacc
TF_ACC=1 TF_LOG_SDK_PROTO=OFF go test $(go list ./... |grep -v 'vendor') -v -run=TestAccTFENoCodeModuleDataSource_public -v -timeout 15m
?       github.com/hashicorp/terraform-provider-tfe     [no test files]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-tfe/internal/client     (cached) [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-tfe/internal/logging    (cached) [no tests to run]
?       github.com/hashicorp/terraform-provider-tfe/version     [no test files]
=== RUN   TestAccTFENoCodeModuleDataSource_public
--- PASS: TestAccTFENoCodeModuleDataSource_public (4.19s)
PASS
ok      github.com/hashicorp/terraform-provider-tfe/internal/provider   (cached)

@catsby catsby marked this pull request as ready for review February 2, 2024 22:24
@catsby catsby requested a review from a team as a code owner February 2, 2024 22:24
@catsby catsby changed the title Data source module Data source no-code module Feb 2, 2024
Copy link
Contributor

@sebasslash sebasslash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes overall look good to me. Ran tests locally ✅ :

=== RUN   TestAccTFENoCodeModuleDataSource_public
--- PASS: TestAccTFENoCodeModuleDataSource_public (8.01s)
PASS

One minor thing before I rebase to run against CI as this will prevent you from making further code changes.

internal/provider/data_source_no_code_module.go Outdated Show resolved Hide resolved
Copy link
Contributor

@sebasslash sebasslash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Rebasing onto a local branch

@sebasslash
Copy link
Contributor

See #1246

@catsby
Copy link
Contributor Author

catsby commented Feb 6, 2024

Closing in favor of #1246

@catsby catsby closed this Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants