-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TF-9704 Added organization_scoped resource to oauth client #1142
Merged
netramali
merged 10 commits into
main
from
Netra2104/TF-9704-add-organization-scoped-resource-oauth-client
Apr 9, 2024
Merged
TF-9704 Added organization_scoped resource to oauth client #1142
netramali
merged 10 commits into
main
from
Netra2104/TF-9704-add-organization-scoped-resource-oauth-client
Apr 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netra2104
force-pushed
the
Netra2104/TF-9704-add-organization-scoped-resource-oauth-client
branch
from
November 17, 2023 16:14
e470e94
to
a2893cc
Compare
hs26gill
approved these changes
Nov 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the lint issue else LGTM!
Netra2104
force-pushed
the
Netra2104/TF-9704-add-organization-scoped-resource-oauth-client
branch
2 times, most recently
from
November 27, 2023 20:27
e83f419
to
17dc929
Compare
Uk1288
reviewed
Nov 27, 2023
Co-authored-by: UKEME BASSEY <ukeme.bassey@hashicorp.com>
Co-authored-by: UKEME BASSEY <ukeme.bassey@hashicorp.com>
Netra2104
force-pushed
the
Netra2104/TF-9704-add-organization-scoped-resource-oauth-client
branch
from
November 29, 2023 16:10
502751c
to
1972dc8
Compare
Netra2104
commented
Nov 29, 2023
…source-oauth-client
…source-oauth-client
…source-oauth-client
…source-oauth-client
brandonc
approved these changes
Apr 8, 2024
netramali
deleted the
Netra2104/TF-9704-add-organization-scoped-resource-oauth-client
branch
April 9, 2024 20:02
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
OrganizationScoped was added to the oauth client so that the user can scope it to an organization optionally.
By default the value of organization scoped is true when it is first created.
Remember to:
Testing plan
Run the tests locally
External links
Include any links here that might be helpful for people reviewing your PR. If there are none, feel free to delete this section.
Output from acceptance tests
Please run applicable acceptance tests locally and include the output here. See testing.md to learn how to run acceptance tests.
If you are an external contributor, your contribution(s) will first be reviewed before running them against the project's CI pipeline.
Documentation