Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add excluded_workspace_ids to policy sets data source #1035

Merged

Conversation

Netra2104
Copy link
Contributor

@Netra2104 Netra2104 commented Sep 1, 2023

Description

excluded_workspace_ids needs to be added to the policy sets data source to accompany the workspace_policy_set_exclusion resource.

Remember to:

External links

Include any links here that might be helpful for people reviewing your PR. If there are none, feel free to delete this section.

Output from acceptance tests

Please run applicable acceptance tests locally and include the output here. See testing.md to learn how to run acceptance tests.

If you are an external contributor, your contribution(s) will first be reviewed before running them against the project's CI pipeline.

--- PASS: TestAccTFEPolicySetDataSource_basic (6.74s)
PASS

--- PASS: TestAccTFEPolicySetDataSourceOPA_basic (5.83s)
PASS

--- PASS: TestAccTFEPolicySetDataSource_notFound (2.19s)
PASS
...

Screenshot 2023-09-05 at 2 05 46 PM

@Netra2104 Netra2104 force-pushed the Netra2104/TF-7898-add_excluded_workspace_ids_to_policy_set branch from 75d4998 to d638746 Compare September 5, 2023 17:00
@Netra2104 Netra2104 marked this pull request as ready for review September 5, 2023 17:13
@Netra2104 Netra2104 requested a review from a team as a code owner September 5, 2023 17:13
@Netra2104 Netra2104 force-pushed the Netra2104/TF-7898-add_excluded_workspace_ids_to_policy_set branch from d638746 to a5d440e Compare September 5, 2023 19:43
Copy link
Contributor

@hs26gill hs26gill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Netra2104 Netra2104 merged commit 01abda0 into main Sep 6, 2023
8 checks passed
@Netra2104 Netra2104 deleted the Netra2104/TF-7898-add_excluded_workspace_ids_to_policy_set branch September 6, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants