Handle slashes in email addresses for tfe_org_member import

hashicorp · Jan 26, 2023 · 035ae10 · 035ae10
1 parent 96c72e5
commit 035ae10
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 8 deletions.
diff --git a/tfe/resource_tfe_organization_membership.go b/tfe/resource_tfe_organization_membership.go
@@ -121,13 +121,8 @@ func resourceTFEOrganizationMembershipImporter(ctx context.Context, d *schema.Re
 	// Import formats:
 	//  - <ORGANIZATION MEMBERSHIP ID>
 	//  - <organization name>/<user email>
-	s := strings.Split(d.Id(), "/")
-	if len(s) >= 3 {
-		return nil, fmt.Errorf(
-			"invalid organization membership input format: %s (expected <ORGANIZATION>/<USER EMAIL> or <ORGANIZATION MEMBERSHIP ID>)",
-			d.Id(),
-		)
-	} else if len(s) == 2 {
+	s := strings.SplitN(d.Id(), "/", 2)
+	if len(s) == 2 {
 		org := s[0]
 		email := s[1]
 		orgMembership, err := fetchOrganizationMemberByNameOrEmail(ctx, config.Client, org, "", email)

diff --git a/tfe/resource_tfe_organization_membership_test.go b/tfe/resource_tfe_organization_membership_test.go
@@ -103,7 +103,7 @@ func TestAccTFEOrganizationMembershipImport_invalidImportId(t *testing.T) {
 				ResourceName:  "tfe_organization_membership.foobar",
 				ImportState:   true,
 				ImportStateId: fmt.Sprintf("%s/%s/someOtherString", orgName, email),
-				ExpectError:   regexp.MustCompile("invalid organization membership input format"),
+				ExpectError:   regexp.MustCompile(fmt.Sprintf("error retrieving user with email %s/someOtherString from organization %s", email, orgName)),
 			},
 			{
 				ResourceName:  "tfe_organization_membership.foobar",