Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate project_services in 2.x. #4587

Merged
merged 1 commit into from
Oct 1, 2019

Conversation

modular-magician
Copy link
Collaborator

@modular-magician modular-magician commented Sep 30, 2019

Original Author: @ndmckinley

`google_project_services`

Signed-off-by: Modular Magician <magic-modules@google.com>
@nat-henderson nat-henderson merged commit 8db1e31 into hashicorp:master Oct 1, 2019
@yinzara
Copy link

yinzara commented Oct 16, 2019

I believe that this need to be revisited.

When a project has numerous services enabled, using the "google_project_service" resource causes multiple API requests during a refresh which can often go over the API limits. By using the "google_project_services" resource, this is limited to a single API call. I was only able to fix issues with my project by swapping to using the now deprecated "google_project_services"

@nat-henderson
Copy link
Contributor

Definitely. We added batching to google_project_service to prevent that issue.

@ghost
Copy link

ghost commented Nov 1, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants