Fix deletion_protection fields specified as strings #19989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[upstream:794b64eb07a96b54ad6bca3e83d2de23afbb5201] Signed-off-by: Modular Magician <magic-modules@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #19747
These happen to work because of Terraform's particularly aggressive type coercion, but our docs should specify the true types where possible. This will turn some entries from
""to `` (blank). Working on correcting for those in a followup change, I'll probably gate submission of this on finishing those (and merging both PRs independently will have no merge conflicts, but combine to correct all the pages due to a helpful-for-once cross merge).I thought these might have been introduced during the Go rewrite, but turns out they werent! They were like that in Ruby too.
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#11981