Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add output for sole tenant node names #4274

Open
tamilvs opened this issue Aug 16, 2019 · 3 comments
Open

Add output for sole tenant node names #4274

tamilvs opened this issue Aug 16, 2019 · 3 comments

Comments

@tamilvs
Copy link

tamilvs commented Aug 16, 2019

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

Current sole tenant node output has only nodegroup name. It would be great if you add output of node names as well to schedule the VM to specific nodes. In GCP console we are able to get the node name and terraform node affinity lables are able to launch vns to specific node. If we get node name output directly it would be better to map them with remote state for auto inputs.

New or Affected Resource(s)

*google_compute_node_group

References

  • #0000

b/356665702

@ghost ghost added the enhancement label Aug 16, 2019
@tamilvs
Copy link
Author

tamilvs commented Aug 20, 2019

No one owning this issue :(

@paddycarver paddycarver added this to the Backlog milestone Dec 6, 2019
modular-magician added a commit to modular-magician/terraform-provider-google that referenced this issue Dec 1, 2020
…hicorp#4274)

Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician added a commit that referenced this issue Dec 1, 2020
…) (#7913)

Signed-off-by: Modular Magician <magic-modules@google.com>
@rileykarson
Copy link
Collaborator

We could consider a datasource that implements https://cloud.google.com/compute/docs/reference/rest/v1/nodeGroups/listNodes, although we probably don't want to add this directly to the resource.

@rileykarson rileykarson modified the milestones: Backlog, Goals Apr 24, 2023
@github-actions github-actions bot added forward/review In review; remove label to forward service/compute-sole-tenancy labels Oct 25, 2023
@roaks3
Copy link
Collaborator

roaks3 commented Jul 31, 2024

This is a case of a plural datasource. See #8255 for more info and some light guidelines for implementation.

@roaks3 roaks3 removed the forward/review In review; remove label to forward label Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants