Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

secret_manager_secret_version disable all past verisons #11652

Open
steveoh opened this issue May 6, 2022 · 2 comments
Open

secret_manager_secret_version disable all past verisons #11652

steveoh opened this issue May 6, 2022 · 2 comments

Comments

@steveoh
Copy link

steveoh commented May 6, 2022

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

Currently you cannot choose what happens with old versions of secrets. They are automatically destroyed.

image

It would be great that if when using a secret_manager_secret_version that there was an option to disable the past version rather than destroy them.

image

New or Affected Resource(s)

  • google_secret_manager_secret_version

Potential Terraform Configuration

resource "google_secret_manager_secret_version" "default" {
  secret                = google_secret_manager_secret.default.id
  secret_data           = var.secret_text
  old_version_strategy  = 'disable|destroy'
}

b/302797675

@philip-harvey
Copy link

old_version_strategy should also include the option to do nothing, possibly options would be disable|destroy|ignore

@steveoh
Copy link
Author

steveoh commented Sep 12, 2023

@rileykarson what's the status of this? I don't understand the tags.

@roaks3 roaks3 removed the forward/review In review; remove label to forward label Sep 29, 2023
modular-magician added a commit to modular-magician/terraform-provider-google that referenced this issue Sep 23, 2024
…provider (hashicorp#11652)

Co-authored-by: Nick Elliot <nickelliot@google.com>

[upstream:973809a6e894448e63c8bff820c8fa08c0e59fb5]

Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician added a commit that referenced this issue Sep 23, 2024
…provider (#11652) (#19579)

[upstream:973809a6e894448e63c8bff820c8fa08c0e59fb5]

Signed-off-by: Modular Magician <magic-modules@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants