New Resource: azurerm_stack_hci_windows_virtual_machine
#28333
Conversation
…m into stackhci_virtual_machine
…m into stackhci_virtual_machine
…m into stackhci_virtual_machine
…m into stackhci_virtual_machine
There was a problem hiding this comment.
Hi @teowa ,
Thanks for this PR - I've taken a look through and left some comments inline. If we can fix those up, this should be good to go 👍
| @@ -193,6 +194,11 @@ func (r StackHCIMarketplaceGalleryImageResource) Create() sdk.ResourceFunc { | |||
| return fmt.Errorf("performing create %s: %+v", id, err) | |||
| } | |||
|
|
|||
| // https://github.com/Azure/azure-rest-api-specs/issues/31876 | |||
| if err := resourceMarketplaceGalleryImageWaitForCreated(ctx, *client, id); err != nil { | |||
There was a problem hiding this comment.
This change seems not related with the new resource. It would be better to put it into a separate PR.
There was a problem hiding this comment.
fixed, this is added to another PR #28394
| @@ -181,6 +182,11 @@ func (r StackHCINetworkInterfaceResource) Create() sdk.ResourceFunc { | |||
| return fmt.Errorf("performing create %s: %+v", id, err) | |||
| } | |||
|
|
|||
| // https://github.com/Azure/azure-rest-api-specs/issues/31876 | |||
| if err := resourceNetworkInterfaceWaitForCreated(ctx, *client, id); err != nil { | |||
There was a problem hiding this comment.
fixed, this is added to another PR #28394
| @@ -209,6 +210,11 @@ func (r StackHCIVirtualHardDiskResource) Create() sdk.ResourceFunc { | |||
| return fmt.Errorf("performing create %s: %+v", id, err) | |||
| } | |||
|
|
|||
| // https://github.com/Azure/azure-rest-api-specs/issues/31876 | |||
| if err := resourceVirtualHardDiskWaitForCreated(ctx, *client, id); err != nil { | |||
There was a problem hiding this comment.
fixed, this is added to another PR #28394
| @@ -75,6 +76,8 @@ The following arguments are supported: | |||
|
|
|||
| * `storage_path_id` - (Optional) The ID of the Azure Stack HCI Storage Path used for this Marketplace Gallery Image. Changing this forces a new Azure Stack HCI Virtual Hard Disk to be created. | |||
|
|
|||
| -> **Note:** If `storage_path_id` is not specified, it will be assigned by the server. If you experience a diff you may need to add this to `ignore_changes`. | |||
There was a problem hiding this comment.
This change seems not related with the new resource. It would be better to put it into a separate PR.
There was a problem hiding this comment.
fixed, this is added to another PR #28394
| @@ -94,6 +94,8 @@ An `ip_configuration` block supports the following: | |||
|
|
|||
| * `private_ip_address` - (Optional) The IPv4 address of the IP configuration. Changing this forces a new resource to be created. | |||
|
|
|||
| -> **Note:** If `private_ip_address` is not specified, it will be assigned by the server. If you experience a diff you may need to add this to `ignore_changes`. | |||
There was a problem hiding this comment.
fixed, this is added to another PR #28394
|
|
||
| arcMachineId := machines.NewMachineID(id.SubscriptionId, id.ResourceGroup, id.MachineName) | ||
| scopeId := commonids.NewScopeID(arcMachineId.ID()) | ||
| resp, err := clusterClient.Get(ctx, scopeId) |
There was a problem hiding this comment.
| resp, err := clusterClient.Get(ctx, scopeId) | |
| resp, err := client.AzureStackHCI.VirtualMachineInstances.Get(ctx, scopeId) |
| data := acceptance.BuildTestData(t, "azurerm_stack_hci_windows_virtual_machine", "test") | ||
| r := StackHCIWindowsVirtualMachineResource{} | ||
|
|
||
| data.ResourceSequentialTest(t, r, []acceptance.TestStep{ |
There was a problem hiding this comment.
consider using basic->complete->update->basic to test Add/Update/Remove properties
There was a problem hiding this comment.
the complete test case contains extra forceNew properties thus cannot be used to test update
| }) | ||
| } | ||
|
|
||
| func testAccStackHCIWindowsVirtualMachine_complete(t *testing.T) { |
There was a problem hiding this comment.
seems security_type and storage_profile.os_disk_id are not test
There was a problem hiding this comment.
security_type can only set with certain hardware, and os_disk_id is not supported for now, I have removed it.
|
|
||
| * `storage_profile` - (Required) A `storage_profile` block as defined below. | ||
|
|
||
| --- |
There was a problem hiding this comment.
should not use --- here?
There was a problem hiding this comment.
this is generated by internal/tools/website-scaffold/main.go
|
|
||
| * `minimum_memory_mb` - (Required) The minimum memory in Megabytes. Changing this forces a new Azure Stack HCI Windows Virtual Machine to be created. | ||
|
|
||
| * `target_memory_buffer` - (Required) The extra memory that should be reserved for a virtual machine instance at runtime. Possible value can be in the range of `5` to `2000`. Changing this forces a new Azure Stack HCI Windows Virtual Machine to be created. |
There was a problem hiding this comment.
updated, should be percentage
teowa
force-pushed
the
stackhci_virtual_machine
branch
from
3c99428 to
15f5b43
Compare
Community Note
Description
reference:
PR Checklist
For example: “
resource_name_here- description of change e.g. adding propertynew_property_name_here”Changes to existing Resource / Data Source
Testing
The test depends on a pre-deployed Azure Stack HCI (now called Azure Local) cluster.
test log detail
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_stack_hci_windows_virtual_machineThis is a (please select all that apply):
Related Issue(s)
Fixes #0000
Note
If this PR changes meaningfully during the course of review please update the title and description as required.