Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes encryption to customer_managed_key for azurerm_fluid_relay_servers resource #27995

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

npezzotti
Copy link
Contributor

@npezzotti npezzotti commented Nov 12, 2024

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Change the azurerm_fluid_relay_servers resource's encryption argument to customer_managed_key in its documentation. This appears to be the name for the block based on the resource's schema: https://github.com/hashicorp/terraform-provider-azurerm/blob/v4.9.0/internal/services/fluidrelay/fluid_relay_servers_resource.go#L96

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

@npezzotti npezzotti requested review from katbyte and a team as code owners November 12, 2024 22:09
@npezzotti npezzotti changed the title Changes encryption to customer_managed_key Changes encryption to customer_managed_key for fluid_relay_servers resource Nov 12, 2024
@npezzotti npezzotti changed the title Changes encryption to customer_managed_key for fluid_relay_servers resource Changes encryption to customer_managed_key for azurerm_fluid_relay_servers resource Nov 12, 2024
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @npezzotti LGTM 💯

@stephybun stephybun merged commit 305b8c8 into hashicorp:main Nov 13, 2024
18 checks passed
@github-actions github-actions bot added this to the v4.10.0 milestone Nov 13, 2024
@npezzotti npezzotti deleted the update-fluid_relay_servers-doc branch November 18, 2024 18:01
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants