Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR Label Automation Permissions Update & Fail Silently #27990

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

rcskosir
Copy link
Contributor

@rcskosir rcskosir commented Nov 12, 2024

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Changing permissions for pull-requests: write, and adding silent failure.

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

@rcskosir rcskosir added the bug label Nov 12, 2024
@rcskosir rcskosir requested review from katbyte and a team as code owners November 12, 2024 14:41
Copy link
Member

@catriona-m catriona-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rcskosir rcskosir merged commit c5fad8b into main Nov 12, 2024
3 of 5 checks passed
@rcskosir rcskosir deleted the rcsk/pr-label-permissions-change branch November 12, 2024 17:18
@github-actions github-actions bot added this to the v4.10.0 milestone Nov 12, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants