Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove labels for PR triage from generator and yml #27884

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

rcskosir
Copy link
Contributor

@rcskosir rcskosir commented Nov 4, 2024

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Removed bug, enhancement, and breaking change from generated services and ran make generate to remove from yml.
The yml in this PR does not get read for regex, which is what is causing the error on PR triaging.
Follow up PR to correctly add label automation.

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

@rcskosir rcskosir requested review from katbyte and a team as code owners November 4, 2024 21:01
@rcskosir
Copy link
Contributor Author

rcskosir commented Nov 4, 2024

The screenshot below shows the current failure that this PR should fix, since it removes the labels from the yml that can't read regex.
Screenshot 2024-11-04 at 3 21 12 PM

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rcskosir rcskosir merged commit 8a6ea72 into main Nov 5, 2024
27 of 28 checks passed
@rcskosir rcskosir deleted the rcsk/remove-broken-regex branch November 5, 2024 01:41
@github-actions github-actions bot added this to the v4.9.0 milestone Nov 5, 2024
@rcskosir rcskosir added bug and removed enhancement labels Nov 5, 2024
Copy link

github-actions bot commented Dec 7, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants