resource - fix various tests
#27544
Merged
resource - fix various tests
#27544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mbfrahry
commented
Sep 30, 2024
•
mbfrahry
commented
- Bug Fix
- New Feature (ie adding a service, resource, or data source)
- Enhancement
- Breaking Change
stephybun
reviewed
Oct 1, 2024
| @@ -195,6 +195,9 @@ func resourceResourceGroupDelete(d *pluginsdk.ResourceData, meta interface{}) er | |||
| err = pluginsdk.Retry(10*time.Minute, func() *pluginsdk.RetryError { | |||
| results, err := resourceClient.ListByResourceGroupComplete(ctx, id.ResourceGroup, "", "provisioningState", utils.Int32(500)) | |||
| if err != nil { | |||
| if strings.Contains(err.Error(), "could not be found") { | |||
There was a problem hiding this comment.
Error messages can change without us knowing, I wonder if we can check the response code of results using response.WasNotFound(results.HttpResponse) instead?
github-actions
bot
added
size/S
waiting-response
and removed
waiting-response
size/XS
labels
stephybun
reviewed
Oct 15, 2024
| @@ -222,6 +226,9 @@ func resourceResourceGroupDelete(d *pluginsdk.ResourceData, meta interface{}) er | |||
|
|
|||
| deleteFuture, err := client.Delete(ctx, id.ResourceGroup, "") | |||
| if err != nil { | |||
| if strings.Contains(err.Error(), "could not be found") { | |||
There was a problem hiding this comment.
Sorry should have left a comment here as well, could apply the same check on the Response here like we did above?
github-actions
bot
added
size/XS
waiting-response
and removed
waiting-response
size/S
labels
stephybun
approved these changes
Oct 30, 2024
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.