Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New data source: azurerm_storage_blob_content #27492

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

edward-milkey
Copy link

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

This PR proposes adding a new data source to retrieve the content of a blob in a storage account. It would be useful for us to be able to access configuration data stored in our blobs. Our data is small and text-only so it should be OK to be stored in state.

Using a separate data source to access blob content seems to mirror how the GCP provider does it (separate data source for object and object content). It also avoids changing the behavior of the existing azurerm_storage_blob data source for users that do not need the blob content.

The ability to access blob content was requested in #18779. This PR attempts to provide an easy way to retrieve blob content for users that need it.

Thank you for your consideration.

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)
❯ make acctests SERVICE="storage" TESTARGS="-run=TestAccDataSourceStorageBlobContent_basic" TESTTIMEOUT="10m"
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/storage -run=TestAccDataSourceStorageBlobContent_basic -timeout 10m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccDataSourceStorageBlobContent_basic
=== PAUSE TestAccDataSourceStorageBlobContent_basic
=== CONT  TestAccDataSourceStorageBlobContent_basic
--- PASS: TestAccDataSourceStorageBlobContent_basic (123.64s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/storage	127.487s

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • New Data Source: azurerm_storage_blob_content - new data source to retrieve storage blob content [GH-00000]

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants