-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Resource: azurerm_data_protection_backup_instance_mysql_flexible_server
#27464
base: main
Are you sure you want to change the base?
New Resource: azurerm_data_protection_backup_instance_mysql_flexible_server
#27464
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @neil-yechenwei,
Thanks for this PR - I've taken a look through and left some comments inline. If we can fix those up, this should be good to go 👍
...al/services/dataprotection/data_protection_backup_instance_mysql_flexible_server_resource.go
Show resolved
Hide resolved
...al/services/dataprotection/data_protection_backup_instance_mysql_flexible_server_resource.go
Outdated
Show resolved
Hide resolved
...al/services/dataprotection/data_protection_backup_instance_mysql_flexible_server_resource.go
Outdated
Show resolved
Hide resolved
...al/services/dataprotection/data_protection_backup_instance_mysql_flexible_server_resource.go
Show resolved
Hide resolved
website/docs/r/data_protection_backup_instance_mysql_flexible_server.html.markdown
Outdated
Show resolved
Hide resolved
@ms-zhenhua , thanks for the comments. I updated PR. Please take another look. |
Hi @neil-yechenwei , thank you for your update. LGTM~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test failure
------- Stdout: -------
=== RUN TestAccDataProtectionBackupInstanceMySQLFlexibleServer_basic
=== PAUSE TestAccDataProtectionBackupInstanceMySQLFlexibleServer_basic
=== CONT TestAccDataProtectionBackupInstanceMySQLFlexibleServer_basic
testcase.go:173: Step 1/3 error: Error running apply: exit status 1
Error: creating Flexible Server (Subscription: "*******"
Resource Group Name: "acctest-dataprotection-241016175940838067"
Flexible Server Name: "acctest-mysqlfs-241016175940838067"): polling after Create: polling failed: the Azure API returned the following error:
Status: "ZoneNotAvailableForRegion"
Code: ""
Message: "The requested size for resource is currently not available in this zone. Please try another zone or deploy to a different location"
Activity Id: ""
---
API Response:
----[start]----
{"name":"d4b8a22a-f57b-4863-965a-cf540392eb18","status":"Failed","startTime":"2024-10-16T18:00:08.933Z","error":{"code":"ZoneNotAvailableForRegion","message":"The requested size for resource is currently not available in this zone. Please try another zone or deploy to a different location"}}
-----[end]-----
with azurerm_mysql_flexible_server.test,
on terraform_plugin_test.tf line 37, in resource "azurerm_mysql_flexible_server" "test":
37: resource "azurerm_mysql_flexible_server" "test" {
--- FAIL: TestAccDataProtectionBackupInstanceMySQLFlexibleServer_basic (223.58s)
FAIL
f7ebf2f
to
66f37c5
Compare
@katbyte , I updated PR. Please take another look. Below is the test result that I just now triggered. |
Community Note
Description
This PR is to support Data Protection Backup Instance for MySQL FS.
API Reference: https://github.com/Azure/azure-rest-api-specs/tree/main/specification/dataprotection/resource-manager/Microsoft.DataProtection/stable/2024-04-01
Overview: https://learn.microsoft.com/en-us/azure/postgresql/flexible-server/concepts-backup-restore#long-term-retention-preview
Note: This PR is referring the existing Backup Instances in RP https://github.com/hashicorp/terraform-provider-azurerm/tree/main/internal/services/dataprotection.
PR Checklist
For example: “
resource_name_here
- description of change e.g. adding propertynew_property_name_here
”Changes to existing Resource / Data Source
Testing
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_data_protection_backup_instance_mysql_flexible_server
This is a (please select all that apply):
Note
If this PR changes meaningfully during the course of review please update the title and description as required.