-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_nginx_deployment - support NGINX App Protect WAF #27454
Open
arpith-f5
wants to merge
5
commits into
hashicorp:main
Choose a base branch
from
arpith-f5:nginxaas_nap
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NGINXaaS now supports NGINX App Protect WAF. This commit includes changes to enable/disable WAF while creation or updating an NGINXaaS deployment.
arpith-f5
changed the title
NGINXaaS App Protect
azurerm_nginx_deployment - support NGINX App Protect WAF
Sep 20, 2024
Looks like some vendor checks are failing? |
puneetsarna
reviewed
Sep 25, 2024
puneetsarna
reviewed
Sep 25, 2024
puneetsarna
reviewed
Sep 25, 2024
puneetsarna
reviewed
Sep 25, 2024
puneetsarna
reviewed
Sep 25, 2024
puneetsarna
reviewed
Sep 25, 2024
puneetsarna
reviewed
Sep 25, 2024
arpith-f5
force-pushed
the
nginxaas_nap
branch
from
September 27, 2024 21:57
c4c0a47
to
4f6d8ec
Compare
I like the newly flattened structure (less nested) to invoke this new feature as well 👍 |
puneetsarna
approved these changes
Oct 4, 2024
Hi @katbyte @stephybun, when you get time would you be able to take a look at this PR. Thanks in advance! |
katbyte
requested changes
Oct 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, we have a test failure needing fixing:
------- Stdout: -------
=== RUN TestAccNginxDeploymentDataSource_nginxappprotect
=== PAUSE TestAccNginxDeploymentDataSource_nginxappprotect
=== CONT TestAccNginxDeploymentDataSource_nginxappprotect
testcase.go:173: Step 1/1 error: Error running apply: exit status 1
Error: scaling is required for `sku` 'standardv2_Monthly', please provide `capacity` or `auto_scale_profiles`
with azurerm_nginx_deployment.test,
on terraform_plugin_test.tf line 75, in resource "azurerm_nginx_deployment" "test":
75: resource "azurerm_nginx_deployment" "test" {
scaling is required for `sku` 'standardv2_Monthly', please provide `capacity`
or `auto_scale_profiles`
--- FAIL: TestAccNginxDeploymentDataSource_nginxappprotect (92.49s)
FAIL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Description
NGINXaaS now supports NGINX App Protect WAF. In order to use WAF, customers need to explicitly enable it while creating/update their NGINXaaS deployment. This commit includes changes to support a new block
nginx_app_protect
inazurerm_nginx_deployment
resource to enable/disable WAF while creation or updating an NGINXaaS deployment.PR Checklist
For example: “
resource_name_here
- description of change e.g. adding propertynew_property_name_here
”Changes to existing Resource / Data Source
Testing
Manually tested create and update of a NGINXaaS deployment with WAF enabled/disabled
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_nginx_deployment
- support NGINX App Protect WAFThis is a (please select all that apply):
Related Issue(s)
Note
If this PR changes meaningfully during the course of review please update the title and description as required.