Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update media service v4.0 clean up #27195

Merged
merged 7 commits into from
Sep 2, 2024
Merged

Update media service v4.0 clean up #27195

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d8ed6b2
Update `media` service v4.0 clean up
magodo Aug 26, 2024
d3b2115
pass ci
magodo Aug 26, 2024
0daaa46
Removing the registration of account filter
magodo Aug 29, 2024
b36dc48
Revert "Removing the registration of account filter"
magodo Aug 30, 2024
ebc3bcd
keep the account filter resource
magodo Aug 30, 2024
5fcdeff
Merge remote-tracking branch 'upstream/main' into media_4_cleaup
magodo Sep 2, 2024
baf710d
Revert labeler issue
magodo Sep 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Removing the registration of account filter
  • Loading branch information
@magodo
magodo committed Aug 29, 2024
commit 0daaa46c272015801fc935c4e0838920b2541e32
5 changes: 0 additions & 5 deletions internal/services/media/registration.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,5 @@ func (r Registration) DataSources() []sdk.DataSource {
}

func (r Registration) Resources() []sdk.Resource {
if !features.FourPointOhBeta() {
return []sdk.Resource{
AccountFilterResource{},
}
}
return []sdk.Resource{}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the confusion @magodo , I think we need to leave this as it is for now and not remove it, since it wasn't feature flagged before 4.0 was released

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@catriona-m Oh.. I see. That makes sense now. I've reverted it back.

}
Loading