Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_storage_account: make large_file_share_enabled optional+computed again #26968

Merged

Conversation

manicminer
Copy link
Contributor

The large_file_share_enabled property is conditionally ForceNew and has a moving default dictated by the service, so make it optional + computed again.

…puted again, since it is conditionally ForceNew and has a moving default
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @manicminer - Just one minor comment to take a look at, otherwise LGTM 👍

internal/services/storage/storage_account_resource_test.go Outdated Show resolved Hide resolved
@github-actions github-actions bot added size/S and removed size/XS labels Aug 15, 2024
@manicminer manicminer merged commit 8beecf1 into main Aug 15, 2024
30 checks passed
@manicminer manicminer deleted the bugfix/storage-account-make-lfs-optional-computer-again branch August 15, 2024 12:03
@github-actions github-actions bot added this to the v3.116.0 milestone Aug 15, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants