azurerm_mssql_database/azurerm_mssql_managed_database - remove Computed for weekly_retention, monthly_retention and yearly_retention

[neil-yechenwei]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

As weekly_retention, monthly_retention and yearly_retention are added the Computed attribute, so TF wouldn't cause difference when they are removed from tf config. Per the latest Hashicorps's suggestion, we should remove Computed.

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevent documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Below failed test cases are also failed with same error on Teamcity Daily Run. So they're not related with this PR.

MSSQL Database (Below failed test cases are also failed with same error on Teamcity. So they are not related with this PR.):

MSSQL Managed Database (Below failed test case is also failed with same error on Teamcity. So it's not related with this PR.):

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_mssql_database/azurerm_mssql_managed_database - remove Computed for weekly_retention, monthly_retention and yearly_retention

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #26906

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[stephybun]

Thanks @neil-yechenwei. Are there no sensible defaults that we can set here or can the default change depending on the config?

[neil-yechenwei]

@stephybun , thanks for the comment. I added default value. Below is the test result I just now triggered.

Below failed test cases are also failed with same error on Teamcity Daily Run. So they're not related with this PR.

Test result for MS SQL Database:

Test Result for SQL Managed Database:

[katbyte]

we are now in 4.0 so i think this needs to be updated

[neil-yechenwei]

@katbyte , thanks for the reminder. I updated PR for v5.0.

[katbyte]

LGTM 🏛️

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.