New Resource: `azurerm_hdinsight_cluster_pool` #25937

jiaweitao001 · 2024-05-11T11:14:37Z

Community Note

Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
Please do not leave "+1" or "me too" comments, they generate extra noise for PR followers and do not help prioritize for review

Description

Add support for azurerm_hdinsight_cluster_pool.

PR Checklist

I have followed the guidelines in our Contributing Documentation.
I have checked to ensure there aren't other open Pull Requests for the same update/change.
I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
I have written new tests for my resource or datasource changes & updated any relevent documentation.
I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
(For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

--- PASS: TestAccHDInsightClusterPools_Update (1390.31s)
--- PASS: TestAccHDInsightClusterPools_complete (1627.15s)
--- PASS: TestAccHDInsightClusterPools_basic (1055.77s)
--- PASS: TestAccHDInsightClusterPools_requiresImport (1043.13s)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

New Resource: azurerm_hdinsight_cluster_pool

This is a (please select all that apply):

Bug Fix
New Feature (ie adding a service, resource, or data source)
Enhancement
Breaking Change

Related Issue(s)

Fixes #0000

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

WodansSon

@jiaweitao001, thanks for opening the PR. It mostly looks good however I have left a couple of suggestions and a question or two that I would like clarification on. If we get those straightened out we can move the PR to the next step. 🚀

WodansSon · 2024-05-18T01:47:01Z

internal/services/hdinsight/hdinsight_cluster_pool_resource.go

+			Required: true,
+			Elem: &pluginsdk.Resource{
+				Schema: map[string]*pluginsdk.Schema{
+					"cluster_pool_version": {


Since the parent field is already called cluster_pool_profile, would it make sense to shorten the name of the child element name to just version to avoid redundancy?

Suggested change

"cluster_pool_version": {

"version": {

Will change.

WodansSon · 2024-05-18T01:49:04Z

internal/services/hdinsight/hdinsight_cluster_pool_resource.go

+			Optional: true,
+			Elem: &pluginsdk.Resource{
+				Schema: map[string]*pluginsdk.Schema{
+					"log_analytics_profile_enabled": {


Same here, since the parent is called log_analytics_profile we can assume the the child fields refer to it so the prefix of this field name seems not needed, what do you think?

Suggested change

"log_analytics_profile_enabled": {

"enabled": {

Will change.

WodansSon · 2024-05-18T01:56:39Z

internal/services/hdinsight/hdinsight_cluster_pool_resource.go

+						ValidateFunc: commonids.ValidateSubnetID,
+					},
+
+					"private_api_server_enabled": {


The name of the field is confusing, is this referring to a private link?

Suggested change

"private_api_server_enabled": {

"private_link_enabled": {

Will change.

WodansSon · 2024-05-18T02:02:00Z

internal/services/hdinsight/hdinsight_cluster_pool_resource.go

+				return fmt.Errorf("reading %s: %+v", *id, err)
+			}
+
+			model := existing.Model


Shouldn't we check to see if the model is nil before we start accessing it's members?

Suggested change

model := existing.Model

model := existing.Model

if model == nil {

return fmt.Errorf("%s model was `nil`", id)

}

Will change.

WodansSon · 2024-05-18T02:08:08Z

internal/services/hdinsight/hdinsight_cluster_pool_resource.go

+}
+
+func expandComputeProfile(profiles []ComputeProfile) hdinsights.ClusterPoolComputeProfile {
+	result := hdinsights.ClusterPoolComputeProfile{
+		VMSize: profiles[0].VmSize,
+	}
+	return result
+}
+
+func expandLogAnalyticsProfile(profiles []LogAnalyticsProfile) *hdinsights.ClusterPoolLogAnalyticsProfile {
+	if len(profiles) == 0 {
+		return nil
+	}
+
+	result := hdinsights.ClusterPoolLogAnalyticsProfile{
+		Enabled:     profiles[0].LogAnalyticsProfileEnabled,
+		WorkspaceId: pointer.To(profiles[0].WorkspaceId),
+	}
+	return &result
+}
+
+func expandNetworkProfile(profiles []NetworkProfile) *hdinsights.ClusterPoolNetworkProfile {
+	if len(profiles) == 0 {
+		return nil
+	}
+
+	result := hdinsights.ClusterPoolNetworkProfile{
+		SubnetId: profiles[0].SubnetId,
+	}
+
+	if profiles[0].PrivateApiServerEnabled {
+		result.EnablePrivateApiServer = pointer.To(true)
+	}
+
+	if profiles[0].OutboundType != "" {
+		result.OutboundType = pointer.To(hdinsights.OutboundType(profiles[0].OutboundType))
+	}
+	return &result
+}
+
+func flattenClusterPoolProfile(input *hdinsights.ClusterPoolProfile) []ClusterPoolProfile {
+	result := make([]ClusterPoolProfile, 0)
+	if input == nil {
+		return result
+	}
+
+	profile := ClusterPoolProfile{
+		ClusterPoolVersion: input.ClusterPoolVersion,
+	}
+	result = append(result, profile)
+
+	return result
+}
+
+func flattenComputeProfile(input hdinsights.ClusterPoolComputeProfile) []ComputeProfile {
+	result := make([]ComputeProfile, 0)
+	profile := ComputeProfile{
+		VmSize: input.VMSize,
+	}
+	result = append(result, profile)
+
+	return result
+}
+
+func flattenLogAnalyticsProfile(input *hdinsights.ClusterPoolLogAnalyticsProfile) []LogAnalyticsProfile {
+	result := make([]LogAnalyticsProfile, 0)
+	if input == nil {
+		return result
+	}
+
+	profile := LogAnalyticsProfile{
+		LogAnalyticsProfileEnabled: input.Enabled,
+		WorkspaceId:                pointer.From(input.WorkspaceId),
+	}
+	result = append(result, profile)
+
+	return result
+}
+
+func flattenNetworkProfile(input *hdinsights.ClusterPoolNetworkProfile) []NetworkProfile {
+	result := make([]NetworkProfile, 0)
+	if input == nil {
+		return result
+	}
+
+	profile := NetworkProfile{
+		SubnetId: input.SubnetId,
+	}
+
+	if input.EnablePrivateApiServer != nil {
+		profile.PrivateApiServerEnabled = *input.EnablePrivateApiServer
+	}
+
+	if input.OutboundType != nil {
+		profile.OutboundType = string(*input.OutboundType)
+	}
+	result = append(result, profile)
+
+	return result
+}


I am confused, why are all of these fields lists when all of the expand and flatten functions are not looping over multiple values, they are only looking at the 0 index?

It's because only one set of profile is allowed for them.

Shouldn't we flatten these code blocks then?

As requested by service team POC, I think we'd better keep them this way?

WodansSon · 2024-05-18T02:11:05Z

internal/services/hdinsight/hdinsight_cluster_pool_resource.go

+		"cluster_pool_profile": {
+			Type:     pluginsdk.TypeList,
+			Required: true,


Shouldn't this have a MaxItems property defined for the list?

WodansSon · 2024-05-18T02:11:24Z

internal/services/hdinsight/hdinsight_cluster_pool_resource.go

+		"log_analytics_profile": {
+			Type:     pluginsdk.TypeList,
+			Optional: true,


Same here, Shouldn't this have a MaxItems property defined for the list?

WodansSon · 2024-05-18T02:11:54Z

internal/services/hdinsight/hdinsight_cluster_pool_resource.go

+		"network_profile": {
+			Type:     pluginsdk.TypeList,
+			Optional: true,


and here as well, shouldn't this have a MaxItems property defined for the list?

WodansSon

Hi @jiaweitao001, thank you so much for pushing those changes, this mostly LGTM now, I did add one additional comment. If we can get that updated I think we will be able to move this PR along. 🚀

WodansSon · 2024-06-11T20:23:02Z

internal/services/hdinsight/hdinsight_cluster_pool_resource.go

 			Elem: &pluginsdk.Resource{
 				Schema: map[string]*pluginsdk.Schema{
-					"log_analytics_profile_enabled": {
+					"enabled": {


Can we remove the enabled field completely to conform to the new Hashi 4.0 coding standards? So in this case if the log_analytics_profile block is in the config the profile would be enabled and if the log_analytics_profile is not in the config it would be disabled.

Sure, will change.

WodansSon · 2024-07-23T00:50:37Z

This resource is no longer under development, so I will close it for the time being until we pick it up again at a future date.

github-actions · 2024-08-22T02:14:28Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions bot added documentation dependencies service/hdinsight size/XL labels May 11, 2024

jiaweitao001 marked this pull request as draft May 14, 2024 05:52

WodansSon requested changes May 18, 2024

View reviewed changes

github-actions bot added waiting-response and removed waiting-response labels May 18, 2024

WodansSon requested changes Jun 11, 2024

View reviewed changes

github-actions bot added the waiting-response label Jun 12, 2024

jiaweitao001 added 6 commits June 12, 2024 15:47

temp

0e06ce8

temp2

6d512e1

New Resource: azurerm_hdinsight_cluster_pool

545966d

Udpate attribute names

0882de9

remove log analytics profile unnecessary attribute

08b90eb

update vendor

d5d8bf0

jiaweitao001 force-pushed the hdinsight_cluster_pool branch from fe094ab to d5d8bf0 Compare June 12, 2024 08:25

github-actions bot added waiting-response and removed waiting-response labels Jun 12, 2024

removing feature flags

b3f1510

github-actions bot removed the waiting-response label Jun 13, 2024

Renaming attributes

2f096f9

WodansSon closed this Jul 23, 2024

github-actions bot locked as resolved and limited conversation to collaborators Aug 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Resource: `azurerm_hdinsight_cluster_pool` #25937

New Resource: `azurerm_hdinsight_cluster_pool` #25937

jiaweitao001 commented May 11, 2024

WodansSon left a comment

WodansSon May 18, 2024

jiaweitao001 May 21, 2024

WodansSon May 18, 2024

jiaweitao001 May 21, 2024

WodansSon May 18, 2024

jiaweitao001 May 21, 2024

WodansSon May 18, 2024

jiaweitao001 May 21, 2024

WodansSon May 18, 2024

jiaweitao001 May 21, 2024

WodansSon Jun 13, 2024

jiaweitao001 Jun 13, 2024

WodansSon May 18, 2024

jiaweitao001 May 21, 2024

WodansSon May 18, 2024

jiaweitao001 May 21, 2024

WodansSon May 18, 2024

jiaweitao001 May 21, 2024

WodansSon left a comment

WodansSon Jun 11, 2024

jiaweitao001 Jun 12, 2024

WodansSon commented Jul 23, 2024

github-actions bot commented Aug 22, 2024

New Resource: azurerm_hdinsight_cluster_pool #25937

New Resource: azurerm_hdinsight_cluster_pool #25937

Conversation

jiaweitao001 commented May 11, 2024

Community Note

Description

PR Checklist

Changes to existing Resource / Data Source

Testing

Change Log

Related Issue(s)

WodansSon left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

WodansSon left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

WodansSon commented Jul 23, 2024

github-actions bot commented Aug 22, 2024

New Resource: `azurerm_hdinsight_cluster_pool` #25937

New Resource: `azurerm_hdinsight_cluster_pool` #25937