azurerm_mssql_managed_instance : support new property azure_active_directory_administrator

[sinbai]

• Support azure_active_directory_administrator property. Swagger: https://github.com/Azure/azure-rest-api-specs/blob/5e060c76edd4fab38e9202055062154006463018/specification/sql/resource-manager/Microsoft.Sql/stable/2021-11-01/ManagedInstances.json#L669

• Corrected documentation issue that zone_redundant_enabled should be a property of azurerm_mssql_managed_instance instead of azurerm_sql_managed_instance.

Test results:
https://hashicorp.teamcity.com/buildConfiguration/TF_AzureRM_AZURERM_SERVICE_PUBLIC_MSSQLMANAGEDINSTANCE/113037?buildTab=tests

Fix #17601.

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

[tombuildsstuff]

Since the rest of the provider calls this azure_active_directory_administrator, whilst this has been rebranded, for consistency with the rest of the provider for the moment we should continue calling this azure_active_directory_administrator - we'll handle renaming all of these to microsoft_entra_administrator at the same time (presumably in 4.0) - as such can we update this?

[sinbai]

Yes, the code has been updated. Could you please take another look?

[katbyte]

ty azure active directory also matches the API/SDK names

[catriona-m]

just want to check what the reason is for removing/changing this?

[sinbai]

Hi @catriona-m , thanks for your time. This is because TestAccMsSqlManagedInstanceActiveDirectoryAdministrator_basic fails with the following error.

[catriona-m]

thanks @sinbai. I notice we are getting a similar failure on another test, would it be within the scope of this PR to fix it too?

------- Stdout: -------
=== RUN   TestAccMsSqlManagedInstanceFailoverGroup_update
=== PAUSE TestAccMsSqlManagedInstanceFailoverGroup_update
=== CONT  TestAccMsSqlManagedInstanceFailoverGroup_update
    testcase.go:173: Step 1/9 error: Pre-apply plan check(s) failed:
        azurerm_mssql_managed_instance_failover_group.test - Resource not found in plan ResourceChanges
--- FAIL: TestAccMsSqlManagedInstanceFailoverGroup_update (21.08s)
FAIL

[sinbai]

thanks @sinbai. I notice we are getting a similar failure on another test, would it be within the scope of this PR to fix it too?

------- Stdout: -------
=== RUN   TestAccMsSqlManagedInstanceFailoverGroup_update
=== PAUSE TestAccMsSqlManagedInstanceFailoverGroup_update
=== CONT  TestAccMsSqlManagedInstanceFailoverGroup_update
    testcase.go:173: Step 1/9 error: Pre-apply plan check(s) failed:
        azurerm_mssql_managed_instance_failover_group.test - Resource not found in plan ResourceChanges
--- FAIL: TestAccMsSqlManagedInstanceFailoverGroup_update (21.08s)
FAIL

Hi @catriona-m I have fixed the test. It passed on locally by setting env.ARM_TEST_LOCATION= Westeurope and env.ARM_TEST_LOCATION_ALT = NorthEurope. This means that ARM_TEST_LOCATION and ARM_TEST_LOCATION_ALT need to be paired regions. See the following Configuration requirements from this document for more information.

Managed instances should be deployed to [paired regions](https://docs.azure.cn/en-us/availability-zones/cross-region-replication-azure) for performance reasons. Managed instances that reside in geo-paired regions benefit from a significantly higher geo-replication speed compared to unpaired regions.

Test result:
PASS: TestAccMsSqlManagedInstanceFailoverGroup_update (8437.15s)