Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

d/private_dns_zone: refactoring to use the ListBySubscription API rather than the Resources API #24024

Merged
merged 3 commits into from
Nov 27, 2023
Merged

d/private_dns_zone: refactoring to use the ListBySubscription API rather than the Resources API #24024

merged 3 commits into from
Nov 27, 2023

Commits on Nov 24, 2023

  1. d/private_dns_zone: refactoring to use the ListBySubscription API rat… 

    …her than the Resources API

Similar to #24023 and #24019 this PR refactors the Private DNS Zone data source to use the ListBySubscription API
rather than listing on the Resources API.

This should both improve reliability, since we're no longer hitting the Resources API (which can serve stale data)
but also removes another usage of `Azure/azure-sdk-for-go`
    @tombuildsstuff
    tombuildsstuff committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    9890c54 View commit details
    Browse the repository at this point in the history

  2. resources: registering the ResourceGroups client

    @tombuildsstuff
    tombuildsstuff committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    6cc3b6d View commit details
    Browse the repository at this point in the history

  3. d/private_dns_zone: pulling the Resource Group name from the Resource… 

    … Groups API

Turns out the `ListBySubscription` API returns this in the incorrect casing, so let's normalize this to the expected value
    @tombuildsstuff
    tombuildsstuff committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    96cd2ac View commit details
    Browse the repository at this point in the history