Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_mssql_server
andazurerm_mssql_database
- upgrade fromv5.0/sql
to2023-02-01-preview
#23721azurerm_mssql_server
andazurerm_mssql_database
- upgrade fromv5.0/sql
to2023-02-01-preview
#23721Changes from 42 commits
f3a1560
67d3d6a
7f7d80f
0bc8f6c
6adf29b
50beff6
48e721c
34941b2
800ce59
e67614f
5501102
5b3be66
8a5be7b
afbec78
ac4e7e6
9e3d25b
7331842
e0af006
13ebfb9
24b0139
cd12276
a37fa1c
bab6b57
61f552e
29761c1
e8df8cf
ae4c76c
5b9d4bd
586b7a7
e6d302c
c239009
06775aa
47089e5
f9cd346
2aa5c5e
f4dc7cc
a9311a0
b6a6643
cc95403
7ab0fd3
f5ac348
53f8078
208816f
f90b954
68aa7f1
799f70d
2a2e9f7
b53005b
1400bba
aafc1a0
56f0ae7
7866c4c
c66ed82
04967b0
f8e71eb
3369ae1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to check, when the Server has no Replication Links the API returns a 404 rather than an empty list/value? I've opened hashicorp/go-azure-sdk#716 to give us access to the HTTP Response here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that appears to be the case here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once hashicorp/pandora#3344 has been merged, we can make this:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one appears to be a merge conflict?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still a work in progress due to the SQL ReplicationLinks bug, so can we ignore this bit for now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once hashicorp/pandora#3344 has been merged, we should be able to make this