Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc Fix: Update pim_eligible_role_assignment.html.markdown by removing principal_type as required argument. #23389

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

unique-dominik
Copy link
Contributor

This property is not required (anymore). It gets decided automatically.

➜ terraform plan 
╷
│ Error: Value for unconfigurable attribute
│ 
│   with azurerm_pim_eligible_role_assignment.mgmt_group_owner_group,
│   on enterprise-maintainers.tf line 93, in resource "azurerm_pim_eligible_role_assignment" "mgmt_group_owner_group":
│   93:   principal_type     = "Group"
│ 
│ Can't configure a value for "principal_type": its value will be decided automatically based on the result of applying this
│ configuration.
➜ terraform version
Terraform v1.4.2
on linux_amd64
+ provider registry.terraform.io/hashicorp/azuread v2.41.0
+ provider registry.terraform.io/hashicorp/azurerm v3.68.0
+ provider registry.terraform.io/hashicorp/time v0.9.1

Your version of Terraform is out of date! The latest version
is 1.5.7. You can update by downloading from https://www.terraform.io/downloads.html

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this @unique-dominik

@mbfrahry mbfrahry modified the milestones: Future, v3.75.0 Sep 26, 2023
@mbfrahry mbfrahry changed the title Update pim_eligible_role_assignment.html.markdown Doc Fix: Update pim_eligible_role_assignment.html.markdown by removing principal_type as required argument. Sep 26, 2023
@mbfrahry mbfrahry merged commit e71267e into hashicorp:main Sep 26, 2023
4 checks passed
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants