Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_storage_account: Add support for AzureDNSZone #22583

Merged

Conversation

favoretti
Copy link
Collaborator

@favoretti favoretti commented Jul 18, 2023

TF_ACC=1 go test -v ./internal/services/storage -timeout=1000m -run='TestAccStorageAccount_DNSEndpointTypeAzure'
=== RUN   TestAccStorageAccount_DNSEndpointTypeAzure
=== PAUSE TestAccStorageAccount_DNSEndpointTypeAzure
=== CONT  TestAccStorageAccount_DNSEndpointTypeAzure
--- PASS: TestAccStorageAccount_DNSEndpointTypeAzure (150.99s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/storage	152.828s

@stephybun
Copy link
Member

@favoretti is this ready for review? Or could we close until it's ready for review?

@favoretti
Copy link
Collaborator Author

@stephybun im trying to catch @magodo on slack, since he was apparently working on the same issue - I wanted to collaborate and get this done. We need this badly, I'm just a bit lost in Giovanni and underlying changes that are needed for this to be finalized.

@katbyte
Copy link
Collaborator

katbyte commented Nov 7, 2023

@favoretti - whats the status on this? are yous till trying to reach out to @magodo or?

@magodo
Copy link
Collaborator

magodo commented Nov 7, 2023

I believe this was depending on tombuildsstuff/giovanni#78, but now the customized endpoint/baseUri is directly supported by the giovanni sdk after it migrates to the go-azure-sdk dataplane clients. So I think this PR is good to go now.

@favoretti
Copy link
Collaborator Author

@magodo @katbyte ill rerun the tests tomorrow and will check if it all works. If it does - I'll convert to a normal PR. Sorry I disappeared lately - too much stuff going on work/life wise.

@tombuildsstuff
Copy link
Contributor

Dependent on tombuildsstuff/giovanni#68

@tombuildsstuff
Copy link
Contributor

Dependent on #24213

@favoretti
Copy link
Collaborator Author

Moved dependent on to #24798

@favoretti favoretti marked this pull request as ready for review March 14, 2024 18:31
@favoretti favoretti changed the title WIP: azurerm_storage_account: Add support for AzureDNSZone azurerm_storage_account: Add support for AzureDNSZone Mar 14, 2024
@favoretti
Copy link
Collaborator Author

@tombuildsstuff @katbyte @stephybun yay. local acceptance passes, kicked TC, but otherwise ready for a review!

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment but otherwise LGTM - thanks @favoretti

website/docs/r/storage_account.html.markdown Outdated Show resolved Hide resolved
@tombuildsstuff tombuildsstuff added this to the v3.97.0 milestone Mar 15, 2024
Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>
@favoretti
Copy link
Collaborator Author

@tombuildsstuff apologies, didn't notice I pushed an argument-specific note. Fixed.

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit but otherwise 👍

Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>
@tombuildsstuff tombuildsstuff merged commit 72ac56e into hashicorp:main Mar 15, 2024
32 checks passed
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants