-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_storage_account
: Add support for AzureDNSZone
#22583
azurerm_storage_account
: Add support for AzureDNSZone
#22583
Conversation
favoretti
commented
Jul 18, 2023
•
edited
Loading
edited
@favoretti is this ready for review? Or could we close until it's ready for review? |
@stephybun im trying to catch @magodo on slack, since he was apparently working on the same issue - I wanted to collaborate and get this done. We need this badly, I'm just a bit lost in Giovanni and underlying changes that are needed for this to be finalized. |
5ba8a47
to
fe3dc1d
Compare
@favoretti - whats the status on this? are yous till trying to reach out to @magodo or? |
I believe this was depending on tombuildsstuff/giovanni#78, but now the customized endpoint/baseUri is directly supported by the giovanni sdk after it migrates to the |
fe3dc1d
to
868435a
Compare
868435a
to
b0b7518
Compare
Dependent on tombuildsstuff/giovanni#68 |
Dependent on #24213 |
Moved dependent on to #24798 |
b0b7518
to
41b1134
Compare
azurerm_storage_account
: Add support for AzureDNSZone
azurerm_storage_account
: Add support for AzureDNSZone
@tombuildsstuff @katbyte @stephybun yay. local acceptance passes, kicked TC, but otherwise ready for a review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment but otherwise LGTM - thanks @favoretti
Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>
@tombuildsstuff apologies, didn't notice I pushed an argument-specific note. Fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit but otherwise 👍
Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |