-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linux and windows virtual machine admin password validations #20558
Linux and windows virtual machine admin password validations #20558
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR @juanjojulian. The conditions for both linux and windows admin passwords look to be identical, so could we consolidate the validation logic into one file called admin_password.go
and have both resources reference it?
Hi @stephybun both conditions are very similar but Windows and Linux admin passwords have different length requirements, you probably got confused by a typo in one of the comments in the code, sorry, already corrected it. Windows: Linux: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @juanjojulian LGTM 👍
This functionality has been released in v3.45.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Related to #20400
Adding validations for
azurerm_linux_virtual_machine
andazurerm_windows_virtual_machine
admin_password
to fulfil Azure API requirements in https://learn.microsoft.com/en-us/rest/api/compute/virtual-machines/create-or-update?tabs=HTTP#osprofile