Linux and windows virtual machine admin password validations

[juanjojulian]

Related to #20400

Adding validations for azurerm_linux_virtual_machine and azurerm_windows_virtual_machine admin_password to fulfil Azure API requirements in https://learn.microsoft.com/en-us/rest/api/compute/virtual-machines/create-or-update?tabs=HTTP#osprofile

[stephybun]

Thanks for this PR @juanjojulian. The conditions for both linux and windows admin passwords look to be identical, so could we consolidate the validation logic into one file called admin_password.go and have both resources reference it?

[juanjojulian]

Thanks for this PR @juanjojulian. The conditions for both linux and windows admin passwords look to be identical, so could we consolidate the validation logic into one file called admin_password.go and have both resources reference it?

Hi @stephybun both conditions are very similar but Windows and Linux admin passwords have different length requirements, you probably got confused by a typo in one of the comments in the code, sorry, already corrected it.

Windows:
// adminPassword Min-length is 8 characters and Max-length is 123 characters.

Linux:
// adminPassword Min-length is 6 characters and Max-length is 72 characters.

[stephybun]

Thanks for this @juanjojulian LGTM 👍

[github-actions]

This functionality has been released in v3.45.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.