azurerm_eventhub_namespace - adding wait before deletion

[xiaxyi]

fix failed acctest:

Error: deleting Namespace (Subscription: "*******"
Resource Group Name: "xxxx"
Namespace Name: "xxx"): namespaces.NamespacesClient#Delete: Failure sending request: StatusCode=0 -- Original Error: autorest/azure: Service returned an error. Status=<nil> Code="Conflict" Message="Namespace provisioning in transition. For more information visit https://aka.ms/eventhubsarmexceptions. CorrelationId: e82de239-409f-8f6f-e732-49925f9fc597"
--- FAIL: TestAccEventHubNamespace_withAliasConnectionString (659.94s)

[tombuildsstuff]

this indicates that another resource isn't marking itself as Created/Updated correctly, which resource is causing this?

[xiaxyi]

its disasterRecoveryConfig resource. The situation is the as the same as servicebus namespace. The fix was made in pr #18706

[tombuildsstuff]

So is this fixed in main?

[xiaxyi]

The wait function mentioned in pr #18706 is for servicebus namespace, not for eventhub namespace. The servicebus one was merged. Please feel free to correct me if there is any misunderstanding.

[tombuildsstuff]

Got it - so we should look to revert #18706 and then fix the actual issue here - this type of fix ends up causing larger issues elsewhere unfortunately.

[xiaxyi]

Thanks @tombuildsstuff for the comment. I left my comment in the thread, hope that explains your concern. :)

[katbyte]

@xiaxyi - just wondering if this is still in progress?

[xiaxyi]

@katbyte Thanks for the comment, yes, this is still in the progress, any questions or concerns to the code change?

[katbyte]

As per toms comment, we should be solving this on the resource that is causing the issue, ie the DRC. the wait shouldn't be in the delete, it should be in the update/create//the resource that is putting the eventhub into this state. not the delete of the eventhub. the delete should be erroring if the resource is "undeletable" - this doesn't fix the case if tf creates it and then something else wants to work on it

[xiaxyi]

Thanks @katbyte for the comments, sorry for the late response as I was out of office for the past two weeks.

The DCR's provisioningStatus is checked already in here.

I would like to explain that the wait function used in the deletFunc is to get the eventhub namespace status not the sub-resource ie DCR's status, thus, the eventhub namespace deletion may not be affected if DCR is not existed. We need to ensure the eventhub namespace is ready for deletion.

Feel free to let me know if you have any questions or concerns.

[katbyte]

Thanks for the clarification, LGTM 🦀

[github-actions]

This functionality has been released in v3.39.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.