Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource azurerm_iotcentral_application_network_rule_set #18589

Merged
merged 1 commit into from
Oct 3, 2022

Conversation

myc2h6o
Copy link
Contributor

@myc2h6o myc2h6o commented Sep 30, 2022

Similar to azurerm_servicebus_namespace_network_rule_set_resource, IoT Central Application creates a default Network Rule Set, and it could not be removed even when set to nil/empty explicitly, so adding it with an extracted resource azurerm_iotcentral_application_network_rule_set.

Other changes within this:

  • when parent resource azurerm_iotcentral_application performs an update to the property with UpdateThenPoll, it wipes out the Network Rule Set, so using CreateOrUpdateThenPoll with modifying the existing resource.
  • azurerm_iotcentral_application.sku supports Update, but was missing in the Update function, adding it there. (The update test didn't catch it because the sku in the updated test config is same as the default value.)
  • Supported value ST0 of sku is missing in the doc of azurerm_iotcentral_application, adding it there
  • azurerm_iotcentral_application.template cannot be updated as described here, so changing it to ForceNew. (The update api ignores the new value and doesn't throw an error)
  • Adding few tests for azurerm_iotcentral_application to cover the Update scenarios of its properties

@myc2h6o
Copy link
Contributor Author

myc2h6o commented Sep 30, 2022

I put the update of the azurerm_iotcentral_application here together with this change because azurerm_iotcentral_application_network_rule_set breaks without the change the Update function in azurerm_iotcentral_application. I've put these fixes alone in the separate pr #18590 as well. If it's not ok to mix things together here, please feel free to leave this one alone and review the other one first.

@myc2h6o
Copy link
Contributor Author

myc2h6o commented Sep 30, 2022

Test result
image

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚡

@katbyte katbyte merged commit 6b52772 into hashicorp:main Oct 3, 2022
@github-actions github-actions bot added this to the v3.26.0 milestone Oct 3, 2022
katbyte added a commit that referenced this pull request Oct 3, 2022
@myc2h6o myc2h6o deleted the iotapp_network_rule_set branch October 7, 2022 02:16
@github-actions
Copy link

This functionality has been released in v3.26.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants