Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_linux_web_app - fix runtime setting for java runtime #18155

Closed
wants to merge 8 commits into from

Conversation

xiaxyi
Copy link
Contributor

@xiaxyi xiaxyi commented Aug 29, 2022

The java runtime setting is quite flexible but the api doesn't have any restrictions to the user's input, which means, user can put whatever they want to the java runtime related properties.

We need to set a clear restrictions to these java related properties since service have a very strict reference to the property linuxFxVersion when setting up the app from the backend.

for exmaple:
"linuxFxVersion": "JBOSSEAP|7-java8" works while JBOSSEAP|7.0-java8 does not.

image

fix:#16200

fix:#17144

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Java tests are failing:
image

@xiaxyi
Copy link
Contributor Author

xiaxyi commented Sep 7, 2022

Thanks @katbyte , updated test cases and slot settings

--- PASS: TestAccLinuxWebAppSlot_withJava11Tomcat85 (487.75s)
--- PASS: TestAccLinuxWebAppSlot_withJava11Tomcat8561 (599.95s)
--- PASS: TestAccLinuxWebAppSlot_withJava1109 (601.77s)
--- PASS: TestAccLinuxWebAppSlot_withJava8u242 (603.45s)
--- PASS: TestAccLinuxWebAppSlot_withJava11Tomcat9 (667.39s)
--- PASS: TestAccLinuxWebAppSlot_withJava8JBOSSEAP73 (550.27s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/appservice    550.963s


@peterprumbach-telekom
Copy link

Is this also gonna be implemented for other resources (e.g. azurerm_windows_web_app)?

@github-actions github-actions bot added the size/L label Nov 9, 2022
@xiaxyi xiaxyi changed the title azurerm_linux_web_app: fix runtime setting for java runtime azurerm_linux_web_app - fix runtime setting for java runtime Nov 11, 2022
@diogonborges
Copy link

diogonborges commented Dec 6, 2022

@xiaxyi have you seen this request for changes?
EDIT, just saw that you did

@katbyte what is missing here so this can be merged and included in the next release?

Copy link

@diogonborges diogonborges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackofallops jackofallops mentioned this pull request Dec 14, 2022
1 task
@jackofallops
Copy link
Member

Closing as superseded by 19685

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants