Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_windows_function_app - correcting runtime settings. #18076

Closed
wants to merge 17 commits into from

Conversation

xiaxyi
Copy link
Contributor

@xiaxyi xiaxyi commented Aug 23, 2022

For windows function app running on Java/ PowerShell runtime stack, we need to set below properties, instead of windowsFxVersion:

"javaVersion" -> java runtimes
"powerShellVersion" -> PowerShell core runtimes

For dotnet runtime, since 3.1 is not a valid value for the underlying dotnet clr, we need to save the dotnet version in the windowsFxVersion property. Otherwise, we won't be able to get the information back.

For node app, we should refer to the app_setting {WEBSITE_NODE_DEFAULT_VERSION} property as mentioned in here.

fix #16375
fix #17029
#17173
fix #18947
fix #18998

The .netFrameworkVersion for dotnet_version = 6 isn't set, it's causing the .netframeworkversion sets to the default value 4 and this leads to the custom ~4 in the function runtime field:

fix issue: #16417

@sebader
Copy link
Contributor

sebader commented Oct 25, 2022

any progress on this one?

@bdorplatt
Copy link

any progress on this one?

We have been wondering the same thing, it has been quite a while since this issue was opened and the PR submitted.

@xiaxyi xiaxyi changed the title azurerm_windows_function_app: Correcting runtime settings. azurerm_windows_function_app - correcting runtime settings. Nov 11, 2022
@MajaStojkovic-TomTom

This comment was marked as off-topic.

@jackofallops jackofallops mentioned this pull request Dec 14, 2022
1 task
@jackofallops
Copy link
Member

Closing as superseded by 19685

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.