Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: validate-example uses local built provider #16388

Merged
merged 3 commits into from
Apr 21, 2022
Merged

CI: validate-example uses local built provider #16388

merged 3 commits into from
Apr 21, 2022

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Apr 14, 2022

validate-example uses local built provider to avoid unexpected error
during CI due to incosistency between the example and the latest
released provider version.

@magodo
CI: validate-example uses local built provider
7988744 
`validate-example` uses local built provider to avoid unexpected error
during CI due to incosistency between the example and the latest
released provider version.
@tombuildsstuff tombuildsstuff mentioned this pull request Apr 14, 2022
Merged
tombuildsstuff
tombuildsstuff approved these changes Apr 14, 2022
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments but this otherwise LGTM - thanks @magodo

GNUmakefile Outdated Show resolved Hide resolved
scripts/validate-examples.sh Outdated Show resolved Hide resolved
@tombuildsstuff tombuildsstuff added this to the v3.2.0 milestone Apr 14, 2022
@katbyte katbyte modified the milestones: v3.2.0, v3.3.0 Apr 14, 2022
@github-actions github-actions bot removed the tooling label Apr 15, 2022
@katbyte katbyte merged commit f908fce into hashicorp:main Apr 21, 2022
@github-actions
Copy link

This functionality has been released in v3.3.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@magodo @tombuildsstuff @katbyte