Address TODO items in preparation for 3.0 beta (3/many) #15340
Conversation
github-actions
bot
added
service/consumption
service/cosmosdb
service/firewall
service/frontdoor
service/key-vault
koikonom
changed the title
| // TODO 3.0 - change this to ultra_ssd_disk_iops_read_write | ||
| "disk_iops_read_write": { | ||
| Type: pluginsdk.TypeInt, | ||
| Optional: true, | ||
| Computed: true, | ||
| }, | ||
|
|
||
| // TODO 3.0 - change this to ultra_ssd_disk_iops_read_write | ||
| "disk_mbps_read_write": { | ||
| Type: pluginsdk.TypeInt, | ||
| Optional: true, | ||
| Computed: true, | ||
| }, |
There was a problem hiding this comment.
We should probably add the new properties and deprecate the old ones so people have some warning and can move over?
github-actions
bot
removed
service/signalr
service/log-analytics
service/mssql
koikonom
changed the title
| o := out.Elem.(*pluginsdk.Resource).Schema | ||
| if features.ThreePointOhBeta() { | ||
| o["ultra_ssd_disk_iops_read_write"] = &pluginsdk.Schema{ | ||
| Type: pluginsdk.TypeInt, | ||
| Optional: true, | ||
| Computed: true, | ||
| ConflictsWith: []string{"disk_iops_read_write"}, | ||
| } | ||
|
|
||
| o["ultra_ssd_mbps_read_write"] = &pluginsdk.Schema{ | ||
| Type: pluginsdk.TypeInt, | ||
| Optional: true, | ||
| Computed: true, | ||
| ConflictsWith: []string{"disk_mbps_read_write"}, | ||
| } | ||
| } | ||
|
|
||
| return out |
There was a problem hiding this comment.
is there a reason we are adding these in 3,0 and not just adding the new properties deprecating the old ones and removing in 3.0/waiting fort 4.0 for the removable?
There was a problem hiding this comment.
Alright, based on this and #15390 (comment) I came up with the approach you can see in the commit below
(00c3174)
tl;dr
2.x: There is a deprecation notice to the existing fields
3.x: The fields are renamed.
|
Rebased with latest main branch and resolved conflicts |
…tificate_name_check' and 'backend_pools_send_receive_timeout_seconds' into a 'backend_pool_settings' block
…o `ultra_ssd_disk_iops_read_write` and `ultra_ssd_disk_mbps_read_write`
…` and `ultra_ssd_disk_iops_read_write in favour of `ultra_ssd_disk_mbps_read_write`
|
This functionality has been released in v2.97.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Address TODO items in preparation for 3.0 beta (3/many)