Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_firewall - workaround the destroy failure #15330

Merged
merged 1 commit into from
Feb 9, 2022

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Feb 9, 2022

This PR added a patch on the Azure track1 SDK to adding the required request header (either Accept: application/json or Content-Type: application/json works), which is recently introduced by the NRP.

Fixes #14966

💤  TF_ACC=1 go test -v -timeout=20h ./internal/services/firewall  -run='TestAccFirewall_basic'
=== RUN   TestAccFirewall_basic
=== PAUSE TestAccFirewall_basic
=== CONT  TestAccFirewall_basic
--- PASS: TestAccFirewall_basic (649.02s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/firewall      649.030s

@magodo magodo added bug upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR service/firewall labels Feb 9, 2022
@github-actions github-actions bot added the size/S label Feb 9, 2022
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this @magodo

@tombuildsstuff tombuildsstuff added this to the v2.96.0 milestone Feb 9, 2022
@tombuildsstuff tombuildsstuff merged commit fd8ff57 into hashicorp:main Feb 9, 2022
tombuildsstuff added a commit that referenced this pull request Feb 9, 2022
@github-actions
Copy link

This functionality has been released in v2.96.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug service/firewall size/S upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot destroy Azure Firewall
2 participants