Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_app_service_environment_v3 - update for SDK supported GA changes to service #12932

Merged
merged 23 commits into from
Aug 18, 2021
Merged

azurerm_app_service_environment_v3 - update for SDK supported GA changes to service #12932

merged 23 commits into from
Aug 18, 2021

Conversation

jackofallops
Copy link
Member

@jackofallops jackofallops commented Aug 10, 2021 •
edited
Loading

Closes #12251
Closes #12450
Closes #12577

@jackofallops jackofallops added this to the v2.72.0 milestone Aug 10, 2021
@jackofallops jackofallops requested a review from a team August 10, 2021 19:20
manicminer
manicminer approved these changes Aug 11, 2021
View reviewed changes
Copy link
Contributor

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jackofallops jackofallops modified the milestones: v2.72.0, v2.73.0 Aug 12, 2021
@hbuckle
Copy link
Contributor

hbuckle commented Aug 14, 2021

I don't see internalInboundIpAddresses being exposed here?

@jackofallops
Copy link
Member Author

Hi @hbuckle - They are collectively exposed in inbound_network_dependencies, but on reflection I can see that the discrete values would be useful, so I'll take a look at adding them in whilst I need to also make another change for some functionality that the API does not yet support.

@jackofallops
make subnet ForceNew again until changevnet supported by service. Add…
46e9afa 
… external_inbound_ip_addresses and internal_inbound_ip_addresses attributes
@hbuckle
Copy link
Contributor

hbuckle commented Aug 16, 2021

Ah ok. What a weirdly named property.

@jackofallops
Copy link
Member Author

Ah ok. What a weirdly named property.

Naming things is always a challenge, in this case it's a collection of addresses, ports and a brief description, but I agree "dependencies" is possibly misleading here. In any case, I've added the internal and external inbound IP lists as separate items and I've kicked off the acceptance tests. These take a while to run, but I think everything should be fine to have this in the release this week.

@jackofallops
Copy link
Member Author

Tests look good.

@jackofallops jackofallops merged commit d2724a9 into main Aug 18, 2021
@jackofallops jackofallops deleted the f/asev3-ga branch August 18, 2021 10:10
jackofallops added a commit that referenced this pull request Aug 18, 2021
@jackofallops
Update CHANGELOG.md for #12932
b19837e
@github-actions
Copy link

This functionality has been released in v2.73.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@manicminer manicminer manicminer approved these changes

Assignees
No one assigned
Labels
documentation enhancement service/app-service size/XL
Projects
None yet
Milestone
v2.73.0
3 participants
@jackofallops @hbuckle @manicminer