Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GNUMakefile: Remove GO111MODULE=on and GOFLAGS=-mod=vendor env vars #11461

Merged
merged 1 commit into from
Apr 25, 2021

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Apr 25, 2021

The two environment variables populated in the GNUMakefile: GO111MODULE=on and GOFLAGS=-mod=vendor need to remove, since:

  • Module mode is now on by default since v1.16
  • Setting GOFLAGS=-mod=vendor causes go install failed with: cannot query module due to -mod=vendor

@ghost ghost added the size/XS label Apr 25, 2021
@magodo magodo marked this pull request as draft April 25, 2021 09:40
@magodo magodo marked this pull request as ready for review April 25, 2021 09:43
@katbyte katbyte added this to the v2.57.0 milestone Apr 25, 2021
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@katbyte katbyte merged commit 5bedfee into hashicorp:master Apr 25, 2021
@ghost
Copy link

ghost commented Apr 30, 2021

This has been released in version 2.57.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.57.0"
}
# ... other configuration ...

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants