Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There are a couple of issues with the Logic apps Standard terraform template shared at https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/logic_app_standard #18351

Open
1 task done
NitashaV opened this issue Sep 12, 2022 · 3 comments

Comments

@NitashaV
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform Version

1.0.0

AzureRM Provider Version

3.0.0

Affected Resource(s)/Data Source(s)

azurerm_logic_app_standard

Terraform Configuration Files

https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/logic_app_standard

Debug Output/Panic Output

Standard logic app gets deployed successfully with the current provider (azurerm_logic_app_standard). But it doesn’t have stack settings and workflows won’t work.

Expected Behaviour

The following settings need to be added to the template to ensure workflows work after the deployment

{
"name": "FUNCTIONS_WORKER_RUNTIME",
"value": "node",
"slotSetting": false
},

{
"name": "WEBSITE_NODE_DEFAULT_VERSION",
"value": "~14",
"slotSetting": false
}

Actual Behaviour

The current template deploys fine but key appsettings are missing from the configuration, workflows wont work.

Steps to Reproduce

No response

Important Factoids

No response

References

No response

@Amier3
Copy link
Contributor

Amier3 commented Sep 14, 2022

Hey @NitashaV

Thanks for pointing that out, would you be willing to PR a change to the example config? It'd need to look something like this ( we'd appreciate you testing this out on your end if you take this up ):


/// previous example config here


resource "azurerm_logic_app_standard" "example" {
  name                       = "test-azure-functions"
  location                   = azurerm_resource_group.example.location
  resource_group_name        = azurerm_resource_group.example.name
  app_service_plan_id        = azurerm_app_service_plan.example.id
  storage_account_name       = azurerm_storage_account.example.name
  storage_account_access_key = azurerm_storage_account.example.primary_access_key

 app_settings = {
    "FUNCTIONS_WORKER_RUNTIME"      = "node"
    "WEBSITE_NODE_DEFAULT_VERSION" = "<version>"
  }
}

@HarisAbdulkareem
Copy link

@Amier3 @NitashaV : I can confirm that above configuration is working successfully.
I have tested adding the app settings and it is creating the standard logic app as expected (with correct stack settings).

@xyq175com
Copy link
Contributor

xyq175com commented Oct 31, 2022

Hi, I can work on this and submit a PR later if no one take this out. ;-)

xyq175com added a commit to fidelity-contributions/hashicorp-terraform-provider-azurerm that referenced this issue Nov 23, 2022
xyq175com added a commit to fidelity-contributions/hashicorp-terraform-provider-azurerm that referenced this issue Nov 23, 2022
stephybun pushed a commit that referenced this issue Nov 28, 2022
* fix issue #18351: update a standard logic app with correct stack settings

* fix issue #18351: update a standard logic app with correct stack settings

* Update website/docs/r/logic_app_standard.html.markdown

Co-authored-by: jackofallops <11830746+jackofallops@users.noreply.github.com>

* fix format

Signed-off-by: yan xu <58940428+xyq175com@users.noreply.github.com>

* fix format by using terrafmt

Signed-off-by: yan xu <58940428+xyq175com@users.noreply.github.com>
Co-authored-by: Xu, Yan <yan.xu@fmr.com>
Co-authored-by: jackofallops <11830746+jackofallops@users.noreply.github.com>
favoretti pushed a commit to favoretti/terraform-provider-azurerm that referenced this issue Jan 12, 2023
)

* fix issue hashicorp#18351: update a standard logic app with correct stack settings

* fix issue hashicorp#18351: update a standard logic app with correct stack settings

* Update website/docs/r/logic_app_standard.html.markdown

Co-authored-by: jackofallops <11830746+jackofallops@users.noreply.github.com>

* fix format

Signed-off-by: yan xu <58940428+xyq175com@users.noreply.github.com>

* fix format by using terrafmt

Signed-off-by: yan xu <58940428+xyq175com@users.noreply.github.com>
Co-authored-by: Xu, Yan <yan.xu@fmr.com>
Co-authored-by: jackofallops <11830746+jackofallops@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants