Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service_principal: Support the saml_single_sign_on block with the relay_state property #557

Merged
merged 1 commit into from
Sep 9, 2021

Conversation

manicminer
Copy link
Contributor

@manicminer manicminer commented Sep 7, 2021

Related: #173
Closes: #317

…relay_state` property (resource and data source)
@manicminer
Copy link
Contributor Author

Test results

Resource
Screenshot 2021-09-07 at 20 09 36

Data source
Screenshot 2021-09-07 at 19 02 40

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍕

@manicminer manicminer merged commit f409e0a into main Sep 9, 2021
@manicminer manicminer deleted the feature/service-principal-saml-settings branch September 9, 2021 10:10
manicminer added a commit that referenced this pull request Sep 9, 2021
@github-actions
Copy link

This functionality has been released in v2.2.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Service Principal Resource to support RelayState
2 participants