Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: added example for awscc_sagemaker_image_version #1746

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docs: added example for awscc_sagemaker_image_version #1746

wants to merge 1 commit into from

Conversation

vivekthangamuthu
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request
  • The resources and data sources in this provider are generated from the CloudFormation schema, so they can only support the actions that the underlying schema supports. For this reason submitted bugs should be limited to defects in the generation and runtime code of the provider. Customizing behavior of the resource, or noting a gap in behavior are not valid bugs and should be submitted as enhancements to AWS via the CloudFormation Open Coverage Roadmap.

Relates OR Closes #0000

@vivekthangamuthu vivekthangamuthu force-pushed the improve-awscc_sagemaker_image_version branch from c4eb3ad to 52fe2a4 Compare May 28, 2024 13:57
@vivekthangamuthu vivekthangamuthu force-pushed the improve-awscc_sagemaker_image_version branch from 52fe2a4 to 8222460 Compare May 28, 2024 15:26
@quixoticmonk quixoticmonk self-assigned this May 29, 2024
quixoticmonk
quixoticmonk suggested changes May 29, 2024
View reviewed changes
examples/resources/awscc_sagemaker_image_version/sagemaker_image_version.tf
@@ -0,0 +1,15 @@
resource "awscc_sagemaker_image_version" "example" {
image_name = "example"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
image_name = "example"
image_name = awscc_sagemaker_image.example.image_name

examples/resources/awscc_sagemaker_image_version/sagemaker_image_version.tf
}

resource "awscc_sagemaker_image" "example" {
image_name = awscc_sagemaker_image.example.image_name
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
image_name = awscc_sagemaker_image.example.image_name
image_name = "example"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quixoticmonk quixoticmonk quixoticmonk requested changes

At least 1 approving review is required to merge this pull request.

Assignees

@quixoticmonk quixoticmonk

Labels
documentation examples service/sagemaker waiting-response
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vivekthangamuthu @quixoticmonk @wellsiau-aws