Skip to content

Conversation

@martin-walsh
Copy link
Contributor

@martin-walsh martin-walsh commented Nov 4, 2025

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

N/A

Description

AWS have add support for 10MiB payloads in Kinesis streams.

See #44851

Relations

Closes #44851

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccKinesisStream_maxRecordSizeInKiB PKG=kinesis
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-aws_kinesis_stream-10MiB-payload 🌿...
TF_ACC=1 go test ./internal/service/kinesis/... -v -count 1 -parallel 20 -run='TestAccKinesisStream_maxRecordSizeInKiB'  -timeout 360m -vet=off
2025/11/04 19:18:08 Creating Terraform AWS Provider (SDKv2-style)...
2025/11/04 19:18:08 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccKinesisStream_maxRecordSizeInKiB
=== PAUSE TestAccKinesisStream_maxRecordSizeInKiB
=== CONT  TestAccKinesisStream_maxRecordSizeInKiB
--- PASS: TestAccKinesisStream_maxRecordSizeInKiB (144.34s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/kinesis    151.502s

$ make testacc TESTS=TestAccKinesisStreamDataSource_maxRecordSizeInKiB PKG=kinesis
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-aws_kinesis_stream-10MiB-payload 🌿...
TF_ACC=1 go test ./internal/service/kinesis/... -v -count 1 -parallel 20 -run='TestAccKinesisStreamDataSource_maxRecordSizeInKiB'  -timeout 360m -vet=off
2025/11/04 18:56:21 Creating Terraform AWS Provider (SDKv2-style)...
2025/11/04 18:56:21 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccKinesisStreamDataSource_maxRecordSizeInKiB
=== PAUSE TestAccKinesisStreamDataSource_maxRecordSizeInKiB
=== CONT  TestAccKinesisStreamDataSource_maxRecordSizeInKiB
--- PASS: TestAccKinesisStreamDataSource_maxRecordSizeInKiB (69.43s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/kinesis    76.430s

@martin-walsh martin-walsh requested a review from a team as a code owner November 4, 2025 06:07
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025

✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. service/kinesis Issues and PRs that pertain to the kinesis service. size/XS Managed by automation to categorize the size of a PR. labels Nov 4, 2025
@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. labels Nov 4, 2025
@github-actions github-actions bot added the provider Pertains to the provider itself, rather than any interaction with AWS. label Nov 4, 2025
@ewbankkit ewbankkit added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 4, 2025
@ewbankkit ewbankkit self-assigned this Nov 4, 2025
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Nov 4, 2025
@github-actions github-actions bot added the size/L Managed by automation to categorize the size of a PR. label Nov 4, 2025
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccKinesisStream_\|TestAccKinesisStreamDataSource_' PKG=kinesis ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 HEAD 🌿...
TF_ACC=1 go1.24.8 test ./internal/service/kinesis/... -v -count 1 -parallel 3  -run=TestAccKinesisStream_\|TestAccKinesisStreamDataSource_ -timeout 360m -vet=off
2025/11/04 12:04:16 Creating Terraform AWS Provider (SDKv2-style)...
2025/11/04 12:04:16 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccKinesisStreamDataSource_basic
=== PAUSE TestAccKinesisStreamDataSource_basic
=== RUN   TestAccKinesisStreamDataSource_encryption
=== PAUSE TestAccKinesisStreamDataSource_encryption
=== RUN   TestAccKinesisStreamDataSource_maxRecordSizeInKiB
=== PAUSE TestAccKinesisStreamDataSource_maxRecordSizeInKiB
=== RUN   TestAccKinesisStreamDataSource_pagedShards
=== PAUSE TestAccKinesisStreamDataSource_pagedShards
=== RUN   TestAccKinesisStream_basic
=== PAUSE TestAccKinesisStream_basic
=== RUN   TestAccKinesisStream_disappears
=== PAUSE TestAccKinesisStream_disappears
=== RUN   TestAccKinesisStream_createMultipleConcurrentStreams
=== PAUSE TestAccKinesisStream_createMultipleConcurrentStreams
=== RUN   TestAccKinesisStream_encryptionWithoutKMSKeyThrowsError
=== PAUSE TestAccKinesisStream_encryptionWithoutKMSKeyThrowsError
=== RUN   TestAccKinesisStream_encryption
=== PAUSE TestAccKinesisStream_encryption
=== RUN   TestAccKinesisStream_maxRecordSizeInKiB
=== PAUSE TestAccKinesisStream_maxRecordSizeInKiB
=== RUN   TestAccKinesisStream_shardCount
=== PAUSE TestAccKinesisStream_shardCount
=== RUN   TestAccKinesisStream_retentionPeriod
=== PAUSE TestAccKinesisStream_retentionPeriod
=== RUN   TestAccKinesisStream_shardLevelMetrics
=== PAUSE TestAccKinesisStream_shardLevelMetrics
=== RUN   TestAccKinesisStream_enforceConsumerDeletion
=== PAUSE TestAccKinesisStream_enforceConsumerDeletion
=== RUN   TestAccKinesisStream_tags
=== PAUSE TestAccKinesisStream_tags
=== RUN   TestAccKinesisStream_updateKMSKeyID
=== PAUSE TestAccKinesisStream_updateKMSKeyID
=== RUN   TestAccKinesisStream_basicOnDemand
=== PAUSE TestAccKinesisStream_basicOnDemand
=== RUN   TestAccKinesisStream_updateStreamModeOnDemandToProvisionedStartWithNone
=== PAUSE TestAccKinesisStream_updateStreamModeOnDemandToProvisionedStartWithNone
=== RUN   TestAccKinesisStream_updateStreamModeOnDemandToProvisionedStartWithProvisioned
=== PAUSE TestAccKinesisStream_updateStreamModeOnDemandToProvisionedStartWithProvisioned
=== RUN   TestAccKinesisStream_updateStreamModeProvisionedToOnDemand
=== PAUSE TestAccKinesisStream_updateStreamModeProvisionedToOnDemand
=== RUN   TestAccKinesisStream_failOnBadStreamCountAndStreamModeCombination
=== PAUSE TestAccKinesisStream_failOnBadStreamCountAndStreamModeCombination
=== CONT  TestAccKinesisStreamDataSource_basic
=== CONT  TestAccKinesisStream_retentionPeriod
=== CONT  TestAccKinesisStream_basicOnDemand
--- PASS: TestAccKinesisStream_basicOnDemand (46.93s)
=== CONT  TestAccKinesisStream_failOnBadStreamCountAndStreamModeCombination
--- PASS: TestAccKinesisStreamDataSource_basic (84.85s)
=== CONT  TestAccKinesisStream_updateStreamModeProvisionedToOnDemand
--- PASS: TestAccKinesisStream_retentionPeriod (85.80s)
=== CONT  TestAccKinesisStream_updateStreamModeOnDemandToProvisionedStartWithProvisioned
--- PASS: TestAccKinesisStream_failOnBadStreamCountAndStreamModeCombination (48.05s)
=== CONT  TestAccKinesisStream_updateStreamModeOnDemandToProvisionedStartWithNone
--- PASS: TestAccKinesisStream_updateStreamModeProvisionedToOnDemand (62.84s)
=== CONT  TestAccKinesisStream_createMultipleConcurrentStreams
--- PASS: TestAccKinesisStream_updateStreamModeOnDemandToProvisionedStartWithProvisioned (61.99s)
=== CONT  TestAccKinesisStream_shardCount
--- PASS: TestAccKinesisStream_updateStreamModeOnDemandToProvisionedStartWithNone (116.79s)
=== CONT  TestAccKinesisStream_maxRecordSizeInKiB
--- PASS: TestAccKinesisStream_createMultipleConcurrentStreams (129.65s)
=== CONT  TestAccKinesisStream_encryption
--- PASS: TestAccKinesisStream_maxRecordSizeInKiB (89.41s)
=== CONT  TestAccKinesisStream_encryptionWithoutKMSKeyThrowsError
--- PASS: TestAccKinesisStream_encryptionWithoutKMSKeyThrowsError (37.97s)
=== CONT  TestAccKinesisStream_tags
--- PASS: TestAccKinesisStream_encryption (117.57s)
=== CONT  TestAccKinesisStream_updateKMSKeyID
--- PASS: TestAccKinesisStream_tags (64.11s)
=== CONT  TestAccKinesisStream_enforceConsumerDeletion
--- PASS: TestAccKinesisStream_enforceConsumerDeletion (46.44s)
=== CONT  TestAccKinesisStreamDataSource_pagedShards
--- PASS: TestAccKinesisStream_updateKMSKeyID (80.90s)
=== CONT  TestAccKinesisStream_disappears
--- PASS: TestAccKinesisStreamDataSource_pagedShards (59.24s)
=== CONT  TestAccKinesisStream_basic
--- PASS: TestAccKinesisStream_disappears (44.16s)
=== CONT  TestAccKinesisStreamDataSource_maxRecordSizeInKiB
--- PASS: TestAccKinesisStream_basic (45.78s)
=== CONT  TestAccKinesisStreamDataSource_encryption
--- PASS: TestAccKinesisStreamDataSource_maxRecordSizeInKiB (43.92s)
=== CONT  TestAccKinesisStream_shardLevelMetrics
--- PASS: TestAccKinesisStreamDataSource_encryption (65.19s)
--- PASS: TestAccKinesisStream_shardLevelMetrics (95.40s)
--- PASS: TestAccKinesisStream_shardCount (604.29s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kinesis	757.718s

Copy link
Member

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ewbankkit
Copy link
Contributor

@martin-walsh Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit e807f32 into hashicorp:main Nov 4, 2025
43 of 44 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v6.20.0 milestone Nov 4, 2025
@martin-walsh martin-walsh deleted the f-aws_kinesis_stream-10MiB-payload branch November 4, 2025 23:32
@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025

This functionality has been released in v6.20.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. provider Pertains to the provider itself, rather than any interaction with AWS. service/kinesis Issues and PRs that pertain to the kinesis service. size/L Managed by automation to categorize the size of a PR. size/M Managed by automation to categorize the size of a PR. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for Kinesis 10MiB payloads.

3 participants