-
Notifications
You must be signed in to change notification settings - Fork 9.8k
resource/aws_kinesis_stream: Add support for Kinesis 10MiB payloads. #44915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resource/aws_kinesis_stream: Add support for Kinesis 10MiB payloads. #44915
Conversation
Community GuidelinesThis comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀 Voting for Prioritization
Pull Request Authors
|
|
✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccKinesisStream_\|TestAccKinesisStreamDataSource_' PKG=kinesis ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 HEAD 🌿...
TF_ACC=1 go1.24.8 test ./internal/service/kinesis/... -v -count 1 -parallel 3 -run=TestAccKinesisStream_\|TestAccKinesisStreamDataSource_ -timeout 360m -vet=off
2025/11/04 12:04:16 Creating Terraform AWS Provider (SDKv2-style)...
2025/11/04 12:04:16 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN TestAccKinesisStreamDataSource_basic
=== PAUSE TestAccKinesisStreamDataSource_basic
=== RUN TestAccKinesisStreamDataSource_encryption
=== PAUSE TestAccKinesisStreamDataSource_encryption
=== RUN TestAccKinesisStreamDataSource_maxRecordSizeInKiB
=== PAUSE TestAccKinesisStreamDataSource_maxRecordSizeInKiB
=== RUN TestAccKinesisStreamDataSource_pagedShards
=== PAUSE TestAccKinesisStreamDataSource_pagedShards
=== RUN TestAccKinesisStream_basic
=== PAUSE TestAccKinesisStream_basic
=== RUN TestAccKinesisStream_disappears
=== PAUSE TestAccKinesisStream_disappears
=== RUN TestAccKinesisStream_createMultipleConcurrentStreams
=== PAUSE TestAccKinesisStream_createMultipleConcurrentStreams
=== RUN TestAccKinesisStream_encryptionWithoutKMSKeyThrowsError
=== PAUSE TestAccKinesisStream_encryptionWithoutKMSKeyThrowsError
=== RUN TestAccKinesisStream_encryption
=== PAUSE TestAccKinesisStream_encryption
=== RUN TestAccKinesisStream_maxRecordSizeInKiB
=== PAUSE TestAccKinesisStream_maxRecordSizeInKiB
=== RUN TestAccKinesisStream_shardCount
=== PAUSE TestAccKinesisStream_shardCount
=== RUN TestAccKinesisStream_retentionPeriod
=== PAUSE TestAccKinesisStream_retentionPeriod
=== RUN TestAccKinesisStream_shardLevelMetrics
=== PAUSE TestAccKinesisStream_shardLevelMetrics
=== RUN TestAccKinesisStream_enforceConsumerDeletion
=== PAUSE TestAccKinesisStream_enforceConsumerDeletion
=== RUN TestAccKinesisStream_tags
=== PAUSE TestAccKinesisStream_tags
=== RUN TestAccKinesisStream_updateKMSKeyID
=== PAUSE TestAccKinesisStream_updateKMSKeyID
=== RUN TestAccKinesisStream_basicOnDemand
=== PAUSE TestAccKinesisStream_basicOnDemand
=== RUN TestAccKinesisStream_updateStreamModeOnDemandToProvisionedStartWithNone
=== PAUSE TestAccKinesisStream_updateStreamModeOnDemandToProvisionedStartWithNone
=== RUN TestAccKinesisStream_updateStreamModeOnDemandToProvisionedStartWithProvisioned
=== PAUSE TestAccKinesisStream_updateStreamModeOnDemandToProvisionedStartWithProvisioned
=== RUN TestAccKinesisStream_updateStreamModeProvisionedToOnDemand
=== PAUSE TestAccKinesisStream_updateStreamModeProvisionedToOnDemand
=== RUN TestAccKinesisStream_failOnBadStreamCountAndStreamModeCombination
=== PAUSE TestAccKinesisStream_failOnBadStreamCountAndStreamModeCombination
=== CONT TestAccKinesisStreamDataSource_basic
=== CONT TestAccKinesisStream_retentionPeriod
=== CONT TestAccKinesisStream_basicOnDemand
--- PASS: TestAccKinesisStream_basicOnDemand (46.93s)
=== CONT TestAccKinesisStream_failOnBadStreamCountAndStreamModeCombination
--- PASS: TestAccKinesisStreamDataSource_basic (84.85s)
=== CONT TestAccKinesisStream_updateStreamModeProvisionedToOnDemand
--- PASS: TestAccKinesisStream_retentionPeriod (85.80s)
=== CONT TestAccKinesisStream_updateStreamModeOnDemandToProvisionedStartWithProvisioned
--- PASS: TestAccKinesisStream_failOnBadStreamCountAndStreamModeCombination (48.05s)
=== CONT TestAccKinesisStream_updateStreamModeOnDemandToProvisionedStartWithNone
--- PASS: TestAccKinesisStream_updateStreamModeProvisionedToOnDemand (62.84s)
=== CONT TestAccKinesisStream_createMultipleConcurrentStreams
--- PASS: TestAccKinesisStream_updateStreamModeOnDemandToProvisionedStartWithProvisioned (61.99s)
=== CONT TestAccKinesisStream_shardCount
--- PASS: TestAccKinesisStream_updateStreamModeOnDemandToProvisionedStartWithNone (116.79s)
=== CONT TestAccKinesisStream_maxRecordSizeInKiB
--- PASS: TestAccKinesisStream_createMultipleConcurrentStreams (129.65s)
=== CONT TestAccKinesisStream_encryption
--- PASS: TestAccKinesisStream_maxRecordSizeInKiB (89.41s)
=== CONT TestAccKinesisStream_encryptionWithoutKMSKeyThrowsError
--- PASS: TestAccKinesisStream_encryptionWithoutKMSKeyThrowsError (37.97s)
=== CONT TestAccKinesisStream_tags
--- PASS: TestAccKinesisStream_encryption (117.57s)
=== CONT TestAccKinesisStream_updateKMSKeyID
--- PASS: TestAccKinesisStream_tags (64.11s)
=== CONT TestAccKinesisStream_enforceConsumerDeletion
--- PASS: TestAccKinesisStream_enforceConsumerDeletion (46.44s)
=== CONT TestAccKinesisStreamDataSource_pagedShards
--- PASS: TestAccKinesisStream_updateKMSKeyID (80.90s)
=== CONT TestAccKinesisStream_disappears
--- PASS: TestAccKinesisStreamDataSource_pagedShards (59.24s)
=== CONT TestAccKinesisStream_basic
--- PASS: TestAccKinesisStream_disappears (44.16s)
=== CONT TestAccKinesisStreamDataSource_maxRecordSizeInKiB
--- PASS: TestAccKinesisStream_basic (45.78s)
=== CONT TestAccKinesisStreamDataSource_encryption
--- PASS: TestAccKinesisStreamDataSource_maxRecordSizeInKiB (43.92s)
=== CONT TestAccKinesisStream_shardLevelMetrics
--- PASS: TestAccKinesisStreamDataSource_encryption (65.19s)
--- PASS: TestAccKinesisStream_shardLevelMetrics (95.40s)
--- PASS: TestAccKinesisStream_shardCount (604.29s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/kinesis 757.718sThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
|
@martin-walsh Thanks for the contribution 🎉 👏. |
|
Warning This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them. Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed. |
|
This functionality has been released in v6.20.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Rollback Plan
If a change needs to be reverted, we will publish an updated version of the library.
Changes to Security Controls
N/A
Description
AWS have add support for 10MiB payloads in Kinesis streams.
See #44851
Relations
Closes #44851
References
Output from Acceptance Testing