Skip to content

Conversation

acwwat
Copy link
Contributor

@acwwat acwwat commented Sep 24, 2025

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

n/a

Description

This PR is to update the private zone example in the r/aws_route53_zone doc to demonstrate how to associate multiple VPCs to a private hosted zone.

Relations

Closes #44423

References

n/a

Output from Acceptance Testing

n/a

@acwwat acwwat requested a review from a team as a code owner September 24, 2025 04:41
Copy link
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. service/route53 Issues and PRs that pertain to the route53 service. size/S Managed by automation to categorize the size of a PR. external-maintainer Contribution from a trusted external contributor. labels Sep 24, 2025
@acwwat acwwat force-pushed the d-aws_route53_zone-clarify_multi_vpc_assoc branch from f0d300a to b875a89 Compare September 24, 2025 04:50
@github-actions github-actions bot added the size/XS Managed by automation to categorize the size of a PR. label Sep 24, 2025
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Sep 24, 2025
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@ewbankkit
Copy link
Contributor

@acwwat Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit da3c4ed into hashicorp:main Sep 24, 2025
22 checks passed
Copy link
Contributor

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v6.15.0 milestone Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. external-maintainer Contribution from a trusted external contributor. service/route53 Issues and PRs that pertain to the route53 service. size/S Managed by automation to categorize the size of a PR. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

It is not clear how to associate two VPC
2 participants