Skip to content

Conversation

ramonvermeulen
Copy link

@ramonvermeulen ramonvermeulen commented Sep 23, 2025

Rollback Plan

N/A

Changes to Security Controls

N/A

Description

Adds an argument load_value which defaults to true (so there are no breaking changes). When load_value is set to false both value and insecure_value will not be exposed.

Relations

Closes #44223

References

N/A

Output from Acceptance Testing

make testacc TESTS=TestAccSSMParameterDataSource_loadValue PKG=ssm

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f/ssm-parameter-value 🌿...
TF_ACC=1 go1.24.6 test ./internal/service/ssm/... -v -count 1 -parallel 20 -run='TestAccSSMParameterDataSource_loadValue'  -timeout 360m -vet=off
2025/09/23 10:15:59 Creating Terraform AWS Provider (SDKv2-style)...
2025/09/23 10:15:59 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccSSMParameterDataSource_loadValue
=== PAUSE TestAccSSMParameterDataSource_loadValue
=== CONT  TestAccSSMParameterDataSource_loadValue
--- PASS: TestAccSSMParameterDataSource_loadValue (15.11s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ssm        18.687s

Copy link
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/ssm Issues and PRs that pertain to the ssm service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/S Managed by automation to categorize the size of a PR. labels Sep 23, 2025
@ramonvermeulen ramonvermeulen marked this pull request as ready for review September 23, 2025 08:17
@ramonvermeulen ramonvermeulen requested a review from a team as a code owner September 23, 2025 08:17
Copy link
Contributor

github-actions bot commented Sep 23, 2025

✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible.

@github-actions github-actions bot added the size/M Managed by automation to categorize the size of a PR. label Sep 23, 2025
@ramonvermeulen ramonvermeulen changed the title feat(ssm-parameter): add support to not expose value and insecure_value to tfstate feat(ssm-parameter): added load_value argument to not expose value and insecure_value to tfstate Sep 23, 2025
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ssm Issues and PRs that pertain to the ssm service. size/M Managed by automation to categorize the size of a PR. size/S Managed by automation to categorize the size of a PR. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: aws_ssm_parameter data source toggelable loading values
2 participants