Add provider for pipeline endpoints and resource policy resources and APIs for osis service #44383
Conversation
… APIs Signed-off-by: Taylor Gray <tylgry@amazon.com>
Community GuidelinesThis comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀 Voting for Prioritization
Pull Request Authors
|
|
github-actions
bot
added
needs-triage
| type pipelineResourcePolicyResourceModel struct { | ||
| framework.WithRegionModel | ||
| ID types.String `tfsdk:"id"` | ||
| ResourceARN fwtypes.ARN `tfsdk:"resource_arn"` |
There was a problem hiding this comment.
Is using all capitals the correct Terraform convention? In the API, this is called ResourceArn.
There was a problem hiding this comment.
It is the same convention used for pipeline (
).| type pipelineEndpointResourceModel struct { | ||
| framework.WithRegionModel | ||
| ID types.String `tfsdk:"id"` | ||
| PipelineARN fwtypes.ARN `tfsdk:"pipeline_arn"` |
There was a problem hiding this comment.
Are these conventions with ARN the correct ones for Terraform? They are different from the AWS APIs themselves.
There was a problem hiding this comment.
The same convention is used for pipeline.go
| Timeout: timeout, | ||
| MinTimeout: 10 * time.Second, | ||
| Delay: 30 * time.Second, | ||
| } |
There was a problem hiding this comment.
Should we do anything if we hit CREATE_FAILED?
There was a problem hiding this comment.
I think that may be handled by terraform automatically since the only valid pending status is CREATING. Looking at other providers they do not do any explicit checks for failed statuses
justinretzolk
added
new-resource
Rollback Plan
If a change needs to be reverted, we will publish an updated version of the library.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
Description
Relations
Closes #0000
References
Output from Acceptance Testing