fix: add plan level validation for ttl on route53 record

[quixoticmonk]

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
None

Description

Fixed the aws_route53_record resource to validate TTL requirements at plan time instead of apply time, preventing runtime errors when users forget to specify TTL with records.

1. Schema Modification (/internal/service/route53/record.go)

Before:

"ttl": {
    Type:          schema.TypeInt,
    Optional:      true,
    ConflictsWith: []string{names.AttrAlias},
    RequiredWith:  []string{"records", "ttl"}, // Circular dependency!
},

After:

"ttl": {
    Type:          schema.TypeInt,
    Optional:      true,
    ConflictsWith: []string{names.AttrAlias},
    Description:   "The TTL of the record. Required when records are provided and alias is not used.",
},

2. Added CustomizeDiff Validation

func validateRoute53RecordTTLRequirement(ctx context.Context, diff *schema.ResourceDiff, meta interface{}) error {
    records, hasRecords := diff.GetOk("records")
    alias, hasAlias := diff.GetOk(names.AttrAlias)
    ttl, hasTTL := diff.GetOk("ttl")

    // If records are provided
    if hasRecords && records.(*schema.Set).Len() > 0 {
        // And no alias is provided
        if !hasAlias || len(alias.([]interface{})) == 0 {
            // Then TTL must be provided and greater than 0
            if !hasTTL || ttl.(int) <= 0 {
                return fmt.Errorf("TTL is required when records are provided and alias is not used. " +
                    "Route 53 requires exactly one of: alias target, [TTL and resource records], or traffic policy instance ID")
            }
        }
    }
    return nil
}

3. Updated Resource Definition

return &schema.Resource{
    CreateWithoutTimeout: resourceRecordCreate,
    ReadWithoutTimeout:   resourceRecordRead,
    UpdateWithoutTimeout: resourceRecordUpdate,
    DeleteWithoutTimeout: resourceRecordDelete,
    
    SchemaVersion: 2,
    MigrateState:  recordMigrateState,
    CustomizeDiff: validateRoute53RecordTTLRequirement, // Added this line
    
    Schema: map[string]*schema.Schema{
        // ... rest of schema
    },
}

Test Coverage Added

Unit Tests (/internal/service/route53/record_validation_test.go)

• ✅ Records with TTL - should pass
• ✅ Records without TTL - should fail
• ✅ Records with zero TTL - should fail
• ✅ Alias without TTL - should pass
• ✅ Empty records set - should pass
• ✅ Schema validation tests

Acceptance Tests (/internal/service/route53/record_test.go)

• ✅ TTL validation with records (failure case)
• ✅ TTL validation with records (success case)
• ✅ Alias validation without TTL (success case)
• ✅ Zero TTL with records (failure case)

Relations

Closes #0000

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

go test -parallel 4 ./internal/service/route53 -v
2025/06/13 09:12:25 Initializing Terraform AWS Provider...
=== RUN   TestNormalizeAliasDomainName
=== PAUSE TestNormalizeAliasDomainName
=== RUN   TestCleanZoneID

....
--- PASS: TestParseRecordID (0.00s)
    --- PASS: TestParseRecordID/ABCDEF (0.00s)
    --- PASS: TestParseRecordID/ABCDEF__underscore.example.com_A_set_with1 (0.00s)
    --- PASS: TestParseRecordID/ABCDEF__A (0.00s)
    --- PASS: TestParseRecordID/ABCDEF_prefix._underscore.example.com_A (0.00s)
    --- PASS: TestParseRecordID/ABCDEF_prefix._underscore.example.com_A_set_underscore (0.00s)
    --- PASS: TestParseRecordID/ABCDEF__underscore.example.com_A_set_with_1 (0.00s)
    --- PASS: TestParseRecordID/ABCDEF_prefix._underscore.example.com_A_set (0.00s)
    --- PASS: TestParseRecordID/ABCDEF__underscore.example.com_A_set1 (0.00s)
    --- PASS: TestParseRecordID/ABCDEF_test.example.com_A_set1 (0.00s)
    --- PASS: TestParseRecordID/ABCDEF_test.example.com._A (0.00s)
    --- PASS: TestParseRecordID/ABCDEF__underscore.example.com_A (0.00s)
    --- PASS: TestParseRecordID/ABCDEF_test.example.com (0.00s)
    --- PASS: TestParseRecordID/ABCDEF_test.example.com_A (0.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53	4.708s

[github-actions]

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

• Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
• Please see our prioritization guide for additional information on how the maintainers handle prioritization.
• Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.