Skip to content

feat: update max length for bedrock agent instructions to 20k #42596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

seabornejack
Copy link
Contributor

@seabornejack seabornejack commented May 13, 2025

Description

AWS have updated the maximum instruction character count from 8000 to 20000. The current provider version allows 40 - 8000 characters in the instruction argument.

The below command can validate this new default service quota.

aws service-quotas get-service-quota --service-code bedrock --quota-code L-6E3CDA2D --output table

Output:

----------------------------------------------------------------------------------------------
|                                       GetServiceQuota                                      |
+--------------------------------------------------------------------------------------------+
||                                           Quota                                          ||
|+----------------------+-------------------------------------------------------------------+|
||  Adjustable          |  False                                                            ||
||  GlobalQuota         |  False                                                            ||
||  QuotaAppliedAtLevel |  ACCOUNT                                                          ||
||  QuotaArn            |  arn:aws:servicequotas:eu-west-2:<redacted>:bedrock/L-6E3CDA2D    ||
||  QuotaCode           |  L-6E3CDA2D                                                       ||
||  QuotaName           |  Characters in Agent instructions                                 ||
||  ServiceCode         |  bedrock                                                          ||
||  ServiceName         |  Amazon Bedrock                                                   ||
||  Unit                |  None                                                             ||
||  Value               |  20000.0                                                          ||
|+----------------------+-------------------------------------------------------------------+|

Relations

References

Bedrock Quotas

Output from Acceptance Testing

make testacc ACCTEST_PARALLELISM=3 TESTS=TestAccBedrockAgentAgent_ PKG=bedrockagent 
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.8 test ./internal/service/bedrockagent/... -v -count 1 -parallel 3 -run='TestAccBedrockAgentAgent_'  -timeout 360m -vet=off
2025/05/13 14:24:58 Initializing Terraform AWS Provider...
=== RUN   TestAccBedrockAgentAgent_basic
=== PAUSE TestAccBedrockAgentAgent_basic
=== RUN   TestAccBedrockAgentAgent_full
=== PAUSE TestAccBedrockAgentAgent_full
=== RUN   TestAccBedrockAgentAgent_singlePrompt
=== PAUSE TestAccBedrockAgentAgent_singlePrompt
=== RUN   TestAccBedrockAgentAgent_singlePromptUpdate
=== PAUSE TestAccBedrockAgentAgent_singlePromptUpdate
=== RUN   TestAccBedrockAgentAgent_addPrompt
=== PAUSE TestAccBedrockAgentAgent_addPrompt
=== RUN   TestAccBedrockAgentAgent_guardrail
=== PAUSE TestAccBedrockAgentAgent_guardrail
=== RUN   TestAccBedrockAgentAgent_update
=== PAUSE TestAccBedrockAgentAgent_update
=== RUN   TestAccBedrockAgentAgent_tags
=== PAUSE TestAccBedrockAgentAgent_tags
=== RUN   TestAccBedrockAgentAgent_kms
=== PAUSE TestAccBedrockAgentAgent_kms
=== RUN   TestAccBedrockAgentAgent_agentCollaboration
=== PAUSE TestAccBedrockAgentAgent_agentCollaboration
=== RUN   TestAccBedrockAgentAgent_memoryConfiguration
=== PAUSE TestAccBedrockAgentAgent_memoryConfiguration
=== CONT  TestAccBedrockAgentAgent_basic
=== CONT  TestAccBedrockAgentAgent_agentCollaboration
=== CONT  TestAccBedrockAgentAgent_guardrail
--- PASS: TestAccBedrockAgentAgent_basic (35.44s)
=== CONT  TestAccBedrockAgentAgent_tags
--- PASS: TestAccBedrockAgentAgent_agentCollaboration (53.14s)
=== CONT  TestAccBedrockAgentAgent_kms
--- PASS: TestAccBedrockAgentAgent_guardrail (102.22s)
=== CONT  TestAccBedrockAgentAgent_singlePromptUpdate
--- PASS: TestAccBedrockAgentAgent_tags (82.34s)
=== CONT  TestAccBedrockAgentAgent_addPrompt
--- PASS: TestAccBedrockAgentAgent_kms (66.68s)
=== CONT  TestAccBedrockAgentAgent_memoryConfiguration
--- PASS: TestAccBedrockAgentAgent_memoryConfiguration (35.35s)
=== CONT  TestAccBedrockAgentAgent_update
--- PASS: TestAccBedrockAgentAgent_singlePromptUpdate (57.65s)
=== CONT  TestAccBedrockAgentAgent_singlePrompt
--- PASS: TestAccBedrockAgentAgent_singlePrompt (34.80s)
=== CONT  TestAccBedrockAgentAgent_full
--- PASS: TestAccBedrockAgentAgent_addPrompt (105.40s)
--- PASS: TestAccBedrockAgentAgent_update (77.94s)
--- PASS: TestAccBedrockAgentAgent_full (38.47s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/bedrockagent       240.645s

@seabornejack seabornejack requested a review from a team as a code owner May 13, 2025 12:52
Copy link

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

Copy link

github-actions bot commented May 13, 2025

✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. service/bedrockagent Issues and PRs that pertain to the bedrockagent service. size/XS Managed by automation to categorize the size of a PR. labels May 13, 2025
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@ewbankkit ewbankkit added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels May 13, 2025
Copy link

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@seabornejack seabornejack reopened this May 13, 2025
@ewbankkit
Copy link
Contributor

@seabornejack Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit f5c76a6 into hashicorp:main May 13, 2025
78 checks passed
Copy link

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.98.0 milestone May 13, 2025
@seabornejack seabornejack deleted the f-aws_bedrockagent_agent-update-instructions-validation-20k branch May 14, 2025 07:31
Copy link

This functionality has been released in v5.98.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/bedrockagent Issues and PRs that pertain to the bedrockagent service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants