-
Notifications
You must be signed in to change notification settings - Fork 9.5k
Add the aws_account_primary_contact
data source
#42526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the aws_account_primary_contact
data source
#42526
Conversation
Community GuidelinesThis comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀 Voting for Prioritization
Pull Request Authors
|
✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible. |
55f9394
to
390b92a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccAccount_serial/^PrimaryContact$$/^dataSource' PKG=account
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.8 test ./internal/service/account/... -v -count 1 -parallel 20 -run=TestAccAccount_serial/^PrimaryContact$/^dataSource -timeout 360m -vet=off
2025/05/11 18:01:02 Initializing Terraform AWS Provider...
=== RUN TestAccAccount_serial
=== PAUSE TestAccAccount_serial
=== CONT TestAccAccount_serial
=== RUN TestAccAccount_serial/PrimaryContact
=== RUN TestAccAccount_serial/PrimaryContact/dataSourceBasic
=== RUN TestAccAccount_serial/PrimaryContact/dataSourceAccountID
--- PASS: TestAccAccount_serial (26.72s)
--- PASS: TestAccAccount_serial/PrimaryContact (26.72s)
--- PASS: TestAccAccount_serial/PrimaryContact/dataSourceBasic (10.59s)
--- PASS: TestAccAccount_serial/PrimaryContact/dataSourceAccountID (16.13s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/account 31.366s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
@cavcrosby Thanks for the contribution 🎉 👏. |
Warning This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them. Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed. |
This functionality has been released in v5.98.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Description
Implements a data source for the primary contact information associated with an AWS Account.
Relations
Closes #28013 (PutContactInformation resource implemented in #26123)
References
https://docs.aws.amazon.com/accounts/latest/reference/API_GetContactInformation.html
Output from Acceptance Testing