Skip to content

Add the aws_account_primary_contact data source #42526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 13, 2025

Conversation

cavcrosby
Copy link
Contributor

Description

Implements a data source for the primary contact information associated with an AWS Account.

Relations

Closes #28013 (PutContactInformation resource implemented in #26123)

References

https://docs.aws.amazon.com/accounts/latest/reference/API_GetContactInformation.html

Output from Acceptance Testing

% make testacc TESTS=TestAccAccountPrimaryContactDataSource PKG=account
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.8 test ./internal/service/account/... -v -count 1 -parallel 20 -run='TestAccAccountPrimaryContactDataSource'  -timeout 360m -vet=off
2025/05/07 11:10:48 Initializing Terraform AWS Provider...
=== RUN   TestAccAccountPrimaryContactDataSource_basic
=== PAUSE TestAccAccountPrimaryContactDataSource_basic
=== RUN   TestAccAccountPrimaryContactDataSource_accountID
=== PAUSE TestAccAccountPrimaryContactDataSource_accountID
=== CONT  TestAccAccountPrimaryContactDataSource_basic
=== CONT  TestAccAccountPrimaryContactDataSource_accountID
--- PASS: TestAccAccountPrimaryContactDataSource_basic (11.95s)
--- PASS: TestAccAccountPrimaryContactDataSource_accountID (18.22s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/account    18.353s

Copy link

github-actions bot commented May 7, 2025

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

Copy link

github-actions bot commented May 7, 2025

✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/account Issues and PRs that pertain to the account service. size/XL Managed by automation to categorize the size of a PR. labels May 7, 2025
@cavcrosby cavcrosby force-pushed the f-account-primary-contact branch from 55f9394 to 390b92a Compare May 7, 2025 23:32
@cavcrosby cavcrosby marked this pull request as ready for review May 7, 2025 23:33
@cavcrosby cavcrosby requested a review from a team as a code owner May 7, 2025 23:33
@ewbankkit ewbankkit added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels May 8, 2025
@ewbankkit ewbankkit self-assigned this May 11, 2025
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 11, 2025
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAccount_serial/^PrimaryContact$$/^dataSource' PKG=account
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.8 test ./internal/service/account/... -v -count 1 -parallel 20  -run=TestAccAccount_serial/^PrimaryContact$/^dataSource -timeout 360m -vet=off
2025/05/11 18:01:02 Initializing Terraform AWS Provider...
=== RUN   TestAccAccount_serial
=== PAUSE TestAccAccount_serial
=== CONT  TestAccAccount_serial
=== RUN   TestAccAccount_serial/PrimaryContact
=== RUN   TestAccAccount_serial/PrimaryContact/dataSourceBasic
=== RUN   TestAccAccount_serial/PrimaryContact/dataSourceAccountID
--- PASS: TestAccAccount_serial (26.72s)
    --- PASS: TestAccAccount_serial/PrimaryContact (26.72s)
        --- PASS: TestAccAccount_serial/PrimaryContact/dataSourceBasic (10.59s)
        --- PASS: TestAccAccount_serial/PrimaryContact/dataSourceAccountID (16.13s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/account	31.366s

Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ewbankkit
Copy link
Contributor

@cavcrosby Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit d532496 into hashicorp:main May 13, 2025
46 checks passed
Copy link

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.98.0 milestone May 13, 2025
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 16, 2025
Copy link

This functionality has been released in v5.98.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-data-source Introduces a new data source. service/account Issues and PRs that pertain to the account service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New]: [New Resource]: PutContactInformation and [New Data Source]: GetContactInformation
3 participants