Skip to content

autoscaling: adds new capacity_reservation_specification argument #42380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

hvbamzn
Copy link

@hvbamzn hvbamzn commented Apr 25, 2025

Description

Issue: #42285

Adds support for CapacityReservationSpecification in autoscaling group resource.
https://docs.aws.amazon.com/autoscaling/ec2/userguide/use-ec2-capacity-reservations.html

Relations

Closes #42285

References

Documentation: https://docs.aws.amazon.com/autoscaling/ec2/userguide/use-ec2-capacity-reservations.html

Output from Acceptance Testing

terraform-provider-aws git:(f-odcr_in_autoscaling) make testacc TESTARGS='-run=TestAccAutoScalingGroup_basic\|TestAccAutoScalingGroup_simple\|TestAccAutoScalingGroup_capacityReservationSpecificationBasic\|TestAccAutoScalingGroup_capacityReservationSpecificationWithTarget' PKG=autoscaling
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.8 test ./internal/service/autoscaling/... -v -count 1 -parallel 20  -run=TestAccAutoScalingGroup_basic\|TestAccAutoScalingGroup_simple\|TestAccAutoScalingGroup_capacityReservationSpecificationBasic\|TestAccAutoScalingGroup_capacityReservationSpecificationWithTarget -timeout 360m -vet=off
2025/04/25 11:22:28 Initializing Terraform AWS Provider...
=== RUN   TestAccAutoScalingGroup_basic
=== PAUSE TestAccAutoScalingGroup_basic
=== RUN   TestAccAutoScalingGroup_simple
=== PAUSE TestAccAutoScalingGroup_simple
=== RUN   TestAccAutoScalingGroup_capacityReservationSpecificationBasic
=== PAUSE TestAccAutoScalingGroup_capacityReservationSpecificationBasic
=== RUN   TestAccAutoScalingGroup_capacityReservationSpecificationWithTarget
=== PAUSE TestAccAutoScalingGroup_capacityReservationSpecificationWithTarget
=== CONT  TestAccAutoScalingGroup_basic
=== CONT  TestAccAutoScalingGroup_capacityReservationSpecificationBasic
=== CONT  TestAccAutoScalingGroup_simple
=== CONT  TestAccAutoScalingGroup_capacityReservationSpecificationWithTarget
--- PASS: TestAccAutoScalingGroup_basic (23.78s)
--- PASS: TestAccAutoScalingGroup_capacityReservationSpecificationBasic (55.75s)
--- PASS: TestAccAutoScalingGroup_capacityReservationSpecificationWithTarget (73.04s)
--- PASS: TestAccAutoScalingGroup_simple (148.42s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling	152.298s

...

Copy link

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

Copy link

⚠️ We've detected the following potential issues with your pull request

Changelog Entry Required

The proposed change requires a changelog entry. Please see the Changelog Process section of the contributing guide for information on the changelog generation process.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/autoscaling Issues and PRs that pertain to the autoscaling service. size/XL Managed by automation to categorize the size of a PR. labels Apr 25, 2025
@hvbamzn hvbamzn marked this pull request as ready for review April 25, 2025 18:36
@hvbamzn hvbamzn requested a review from a team as a code owner April 25, 2025 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. needs-triage Waiting for first response or review from a maintainer. service/autoscaling Issues and PRs that pertain to the autoscaling service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ODCR support in autoscaling
2 participants