-
Notifications
You must be signed in to change notification settings - Fork 9.8k
r/aws_elasticache_replication_group: remove auth_token_update_strategy
default
#42336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_elasticache_replication_group: remove auth_token_update_strategy
default
#42336
Conversation
Community GuidelinesThis comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀 Voting for Prioritization
Pull Request Authors
|
ff6ee3c
to
4595702
Compare
…gy` default A state upgrader has been included to remove the default value from state in cases where `auth_token` is not configured. Practitioners will now need to explicitly set a corresponding update strategy when `auth_token` is set. ```console % make testacc PKG=elasticache TESTS=TestAccElastiCacheReplicationGroup_ make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.24.2 test ./internal/service/elasticache/... -v -count 1 -parallel 20 -run='TestAccElastiCacheReplicationGroup_' -timeout 360m -vet=off 2025/04/23 11:30:21 Initializing Terraform AWS Provider... --- PASS: TestAccElastiCacheReplicationGroup_cacheClustersConflictsWithReplicasPerNodeGroup (3.73s) === CONT TestAccElastiCacheReplicationGroup_multiAzNotInVPC --- PASS: TestAccElastiCacheReplicationGroup_ValidationMultiAz_noAutomaticFailover (4.32s) === CONT TestAccElastiCacheReplicationGroup_Validation_globalReplicationGroupIdAndNodeType --- PASS: TestAccElastiCacheReplicationGroup_ClusterMode_singleNode (773.01s) === CONT TestAccElastiCacheReplicationGroup_Engine_Redis_LogDeliveryConfigurations_ClusterMode_Disabled --- PASS: TestAccElastiCacheReplicationGroup_multiAzInVPC (896.61s) === CONT TestAccElastiCacheReplicationGroup_dataTiering --- PASS: TestAccElastiCacheReplicationGroup_NumberCacheClustersMemberClusterDisappearsRemoveMemberCluster_atTargetSize (1097.36s) === CONT TestAccElastiCacheReplicationGroup_GlobalReplicationGroupIDClusterModeValidation_numNodeGroupsOnSecondary --- PASS: TestAccElastiCacheReplicationGroup_Validation_globalReplicationGroupIdAndNodeType (1247.04s) === CONT TestAccElastiCacheReplicationGroup_GlobalReplicationGroupIDClusterMode_basic --- PASS: TestAccElastiCacheReplicationGroup_Redis_basic (1305.43s) === CONT TestAccElastiCacheReplicationGroup_GlobalReplicationGroupID_disappears === CONT TestAccElastiCacheReplicationGroup_GlobalReplicationGroupID_full --- PASS: TestAccElastiCacheReplicationGroup_multiAzNotInVPC_repeated (1327.35s) --- PASS: TestAccElastiCacheReplicationGroup_deprecatedAvailabilityZones_multiAzInVPC (1345.47s) === CONT TestAccElastiCacheReplicationGroup_GlobalReplicationGroupID_basic --- PASS: TestAccElastiCacheReplicationGroup_networkType (1490.73s) === CONT TestAccElastiCacheReplicationGroup_updateDescription --- PASS: TestAccElastiCacheReplicationGroup_Engine_Redis_LogDeliveryConfigurations_ClusterMode_Enabled (1563.23s) === CONT TestAccElastiCacheReplicationGroup_upgrade_4_68_0 --- PASS: TestAccElastiCacheReplicationGroup_dataTiering (848.01s) === CONT TestAccElastiCacheReplicationGroup_upgrade_5_27_0 --- PASS: TestAccElastiCacheReplicationGroup_ClusterModeUpdateNumNodeGroups_scaleDown (1776.95s) === CONT TestAccElastiCacheReplicationGroup_upgrade_6_0_0 --- PASS: TestAccElastiCacheReplicationGroup_vpc (1804.05s) === CONT TestAccElastiCacheReplicationGroup_authToken --- PASS: TestAccElastiCacheReplicationGroup_ipDiscovery (1960.00s) === CONT TestAccElastiCacheReplicationGroup_updateParameterGroup --- PASS: TestAccElastiCacheReplicationGroup_Engine_Redis_LogDeliveryConfigurations_ClusterMode_Disabled (1257.49s) === CONT TestAccElastiCacheReplicationGroup_updateNodeSize --- PASS: TestAccElastiCacheReplicationGroup_multiAzNotInVPC (2373.39s) === CONT TestAccElastiCacheReplicationGroup_updateUserGroups --- PASS: TestAccElastiCacheReplicationGroup_GlobalReplicationGroupIDClusterModeValidation_numNodeGroupsOnSecondary (1345.09s) === CONT TestAccElastiCacheReplicationGroup_updateMaintenanceWindow --- PASS: TestAccElastiCacheReplicationGroup_upgrade_4_68_0 (900.15s) === CONT TestAccElastiCacheReplicationGroup_TagWithOtherModification_numCacheClusters --- PASS: TestAccElastiCacheReplicationGroup_ClusterMode_basic (2566.14s) === CONT TestAccElastiCacheReplicationGroup_Validation_noNodeType --- PASS: TestAccElastiCacheReplicationGroup_Validation_noNodeType (6.12s) === CONT TestAccElastiCacheReplicationGroup_autoMinorVersionUpgrade --- PASS: TestAccElastiCacheReplicationGroup_ClusterMode_updateFromDisabled_Compatible_Enabled (2761.70s) === CONT TestAccElastiCacheReplicationGroup_finalSnapshot --- PASS: TestAccElastiCacheReplicationGroup_updateParameterGroup (884.55s) === CONT TestAccElastiCacheReplicationGroup_tags --- PASS: TestAccElastiCacheReplicationGroup_ClusterMode_nonClusteredParameterGroup (2888.23s) === CONT TestAccElastiCacheReplicationGroup_TagWithOtherModification_version --- PASS: TestAccElastiCacheReplicationGroup_ClusterModeUpdateNumNodeGroups_scaleUp (3141.56s) === CONT TestAccElastiCacheReplicationGroup_NumberCacheClustersMemberClusterDisappearsRemoveMemberCluster_scaleDown --- PASS: TestAccElastiCacheReplicationGroup_ClusterModeUpdateNumNodeGroupsAndReplicasPerNodeGroup_scaleUp (3162.37s) === CONT TestAccElastiCacheReplicationGroup_EngineVersion_update --- PASS: TestAccElastiCacheReplicationGroup_ClusterMode_updateReplicasPerNodeGroup (3240.26s) === CONT TestAccElastiCacheReplicationGroup_disappears --- PASS: TestAccElastiCacheReplicationGroup_updateUserGroups (1374.31s) === CONT TestAccElastiCacheReplicationGroup_Engine_RedisToValkey --- PASS: TestAccElastiCacheReplicationGroup_updateMaintenanceWindow (1368.66s) === CONT TestAccElastiCacheReplicationGroup_EngineVersion_6xToRealVersion --- PASS: TestAccElastiCacheReplicationGroup_TagWithOtherModification_numCacheClusters (1355.46s) === CONT TestAccElastiCacheReplicationGroup_uppercase --- PASS: TestAccElastiCacheReplicationGroup_updateNodeSize (1868.97s) === CONT TestAccElastiCacheReplicationGroup_Redis_EngineVersion_v7 --- PASS: TestAccElastiCacheReplicationGroup_finalSnapshot (1177.73s) === CONT TestAccElastiCacheReplicationGroup_Valkey_basic --- PASS: TestAccElastiCacheReplicationGroup_tags (1237.25s) === CONT TestAccElastiCacheReplicationGroup_Valkey_disableAtRestEncryption --- PASS: TestAccElastiCacheReplicationGroup_disappears (875.25s) === CONT TestAccElastiCacheReplicationGroup_NumberCacheClustersMemberClusterDisappears_addMemberCluster --- PASS: TestAccElastiCacheReplicationGroup_upgrade_6_0_0 (2475.11s) === CONT TestAccElastiCacheReplicationGroup_NumberCacheClustersMemberClusterDisappears_noChange --- PASS: TestAccElastiCacheReplicationGroup_ClusterModeUpdateNumNodeGroupsAndReplicasPerNodeGroup_scaleDown (4287.34s) === CONT TestAccElastiCacheReplicationGroup_NumberCacheClusters_multiAZEnabled --- PASS: TestAccElastiCacheReplicationGroup_GlobalReplicationGroupID_basic (3130.76s) === CONT TestAccElastiCacheReplicationGroup_autoFailoverEnabled_validateNumberCacheClusters --- PASS: TestAccElastiCacheReplicationGroup_autoFailoverEnabled_validateNumberCacheClusters (2.09s) === CONT TestAccElastiCacheReplicationGroup_NumberCacheClusters_autoFailoverEnabled --- PASS: TestAccElastiCacheReplicationGroup_authToken (2744.15s) === CONT TestAccElastiCacheReplicationGroup_NumberCacheClusters_autoFailoverDisabled --- PASS: TestAccElastiCacheReplicationGroup_Valkey_basic (1003.81s) === CONT TestAccElastiCacheReplicationGroup_NumberCacheClusters_basic --- PASS: TestAccElastiCacheReplicationGroup_uppercase (1252.06s) === CONT TestAccElastiCacheReplicationGroup_useCMKKMSKeyID === NAME TestAccElastiCacheReplicationGroup_updateDescription replication_group_test.go:438: Step 1/3 error: Error running apply: exit status 1 Error: waiting for ElastiCache Replication Group (tf-acc-test-4914003034710884471) create: timeout while waiting for state to become 'available' (last state: 'creating', timeout: 1h0m0s) with aws_elasticache_replication_group.test, on terraform_plugin_test.tf line 12, in resource "aws_elasticache_replication_group" "test": 12: resource "aws_elasticache_replication_group" "test" { --- PASS: TestAccElastiCacheReplicationGroup_Redis_EngineVersion_v7 (1212.57s) === CONT TestAccElastiCacheReplicationGroup_transitEncryption7x_basic --- PASS: TestAccElastiCacheReplicationGroup_EngineVersion_6xToRealVersion (1344.24s) === CONT TestAccElastiCacheReplicationGroup_Redis_enableAtRestEncryption === CONT TestAccElastiCacheReplicationGroup_transitEncryption7x_Disable --- PASS: TestAccElastiCacheReplicationGroup_NumberCacheClustersMemberClusterDisappearsRemoveMemberCluster_scaleDown (2116.60s) --- PASS: TestAccElastiCacheReplicationGroup_GlobalReplicationGroupID_disappears (4131.99s) === CONT TestAccElastiCacheReplicationGroup_transitEncryption7x_Enable --- PASS: TestAccElastiCacheReplicationGroup_GlobalReplicationGroupID_full (4110.37s) === CONT TestAccElastiCacheReplicationGroup_transitEncryptionWithAuthToken --- PASS: TestAccElastiCacheReplicationGroup_Valkey_disableAtRestEncryption (1357.37s) === CONT TestAccElastiCacheReplicationGroup_transitEncryption5x --- PASS: TestAccElastiCacheReplicationGroup_upgrade_5_27_0 (3723.04s) === CONT TestAccElastiCacheReplicationGroup_enableSnapshotting --- PASS: TestAccElastiCacheReplicationGroup_autoMinorVersionUpgrade (3014.18s) === CONT TestAccElastiCacheReplicationGroup_clusteringAndCacheNodesCausesError --- PASS: TestAccElastiCacheReplicationGroup_clusteringAndCacheNodesCausesError (0.82s) === CONT TestAccElastiCacheReplicationGroup_Redis_basic_v5 --- PASS: TestAccElastiCacheReplicationGroup_TagWithOtherModification_version (2971.01s) --- FAIL: TestAccElastiCacheReplicationGroup_updateDescription (4385.35s) --- PASS: TestAccElastiCacheReplicationGroup_useCMKKMSKeyID (821.63s) --- PASS: TestAccElastiCacheReplicationGroup_transitEncryption7x_basic (805.26s) --- PASS: TestAccElastiCacheReplicationGroup_GlobalReplicationGroupIDClusterMode_basic (4729.34s) --- PASS: TestAccElastiCacheReplicationGroup_NumberCacheClusters_autoFailoverDisabled (1639.02s) --- PASS: TestAccElastiCacheReplicationGroup_enableSnapshotting (816.33s) --- PASS: TestAccElastiCacheReplicationGroup_Engine_RedisToValkey (2762.12s) --- PASS: TestAccElastiCacheReplicationGroup_Redis_basic_v5 (1013.05s) --- PASS: TestAccElastiCacheReplicationGroup_NumberCacheClustersMemberClusterDisappears_addMemberCluster (2674.64s) --- PASS: TestAccElastiCacheReplicationGroup_NumberCacheClusters_autoFailoverEnabled (2328.77s) --- PASS: TestAccElastiCacheReplicationGroup_NumberCacheClustersMemberClusterDisappears_noChange (2793.34s) --- PASS: TestAccElastiCacheReplicationGroup_transitEncryptionWithAuthToken (1647.52s) --- PASS: TestAccElastiCacheReplicationGroup_Redis_enableAtRestEncryption (1929.99s) --- PASS: TestAccElastiCacheReplicationGroup_NumberCacheClusters_basic (2189.66s) --- PASS: TestAccElastiCacheReplicationGroup_transitEncryption5x (2048.53s) --- PASS: TestAccElastiCacheReplicationGroup_NumberCacheClusters_multiAZEnabled (3287.41s) --- PASS: TestAccElastiCacheReplicationGroup_transitEncryption7x_Disable (2571.06s) --- PASS: TestAccElastiCacheReplicationGroup_transitEncryption7x_Enable (2632.16s) --- PASS: TestAccElastiCacheReplicationGroup_EngineVersion_update (6896.26s) FAIL FAIL github.com/hashicorp/terraform-provider-aws/internal/service/elasticache 10064.069s ``` Failure is transient - the same test passed without error on a subsequent execution. ```console % make testacc PKG=elasticache TESTS=TestAccElastiCacheReplicationGroup_updateDescription make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.24.2 test ./internal/service/elasticache/... -v -count 1 -parallel 20 -run='TestAccElastiCacheReplicationGroup_updateDescription' -timeout 360m -vet=off 2025/04/23 14:29:57 Initializing Terraform AWS Provider... --- PASS: TestAccElastiCacheReplicationGroup_updateDescription (806.32s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/elasticache 811.785s ```
4595702
to
3825e16
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
Warning This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them. Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed. |
This functionality has been released in v6.0.0-beta1 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
A state upgrader has been included to remove the default value from state in cases where
auth_token
is not configured. Practitioners will now need to explicitly set a corresponding update strategy whenauth_token
is set.Relations
Closes #34496
Relates #34460
Relates #33439
Relates #41104
Output from Acceptance Testing
Failure is transient - the same test passed without error on a subsequent execution.