New Resource: aws_cloudfrontkeyvaluestore_keys_exclusive
#42246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unction for checking DIff when performing sync
…tkeyvaluestore_keys_exclusive resource
…e aws_cloudfrontkeyvaluestore_keys_exclusive resource
…s_exclusive resource
…w cloudfrontkeyvaluestore_keys_exclusive
Community GuidelinesThis comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀 Voting for Prioritization
Pull Request Authors
|
github-actions
bot
added
needs-triage
justinretzolk
removed
the
needs-triage
…or the "key" attribute to allow for updates
…val, outOfBandAddition, and disappears_KeyValueStore tests
…ssageContains` ```console % make testacc PKG=cloudfrontkeyvaluestore TESTS=TestAccCloudFrontKeyValueStoreKeysExclusive_ make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.23.8 test ./internal/service/cloudfrontkeyvaluestore/... -v -count 1 -parallel 20 -run='TestAccCloudFrontKeyValueStoreKeysExclusive_' -timeout 360m -vet=off 2025/05/13 09:19:02 Initializing Terraform AWS Provider... --- PASS: TestAccCloudFrontKeyValueStoreKeysExclusive_disappears_KeyValueStore (28.04s) --- PASS: TestAccCloudFrontKeyValueStoreKeysExclusive_value (35.52s) --- PASS: TestAccCloudFrontKeyValueStoreKeysExclusive_basic (36.97s) --- PASS: TestAccCloudFrontKeyValueStoreKeysExclusive_empty (37.18s) --- PASS: TestAccCloudFrontKeyValueStoreKeysExclusive_outOfBandAddition (44.09s) --- PASS: TestAccCloudFrontKeyValueStoreKeysExclusive_outOfBandRemoval (44.10s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/cloudfrontkeyvaluestore 49.935s ```
…pers, tidy up ```console % make testacc PKG=cloudfrontkeyvaluestore TESTS=TestAccCloudFrontKeyValueStoreKeysExclusive_ make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.23.8 test ./internal/service/cloudfrontkeyvaluestore/... -v -count 1 -parallel 20 -run='TestAccCloudFrontKeyValueStoreKeysExclusive_' -timeout 360m -vet=off 2025/05/13 10:12:57 Initializing Terraform AWS Provider... --- PASS: TestAccCloudFrontKeyValueStoreKeysExclusive_disappears_KeyValueStore (28.26s) --- PASS: TestAccCloudFrontKeyValueStoreKeysExclusive_value (35.91s) --- PASS: TestAccCloudFrontKeyValueStoreKeysExclusive_outOfBandRemoval (36.77s) --- PASS: TestAccCloudFrontKeyValueStoreKeysExclusive_empty (37.87s) --- PASS: TestAccCloudFrontKeyValueStoreKeysExclusive_basic (41.17s) --- PASS: TestAccCloudFrontKeyValueStoreKeysExclusive_outOfBandAddition (43.82s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/cloudfrontkeyvaluestore 49.452s ```
github-actions
bot
added
the
service/cloudfront
jar-b
approved these changes
May 13, 2025
There was a problem hiding this comment.
LGTM 🎉
% make testacc PKG=cloudfrontkeyvaluestore TESTS=TestAccCloudFrontKeyValueStoreKeysExclusive_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.8 test ./internal/service/cloudfrontkeyvaluestore/... -v -count 1 -parallel 20 -run='TestAccCloudFrontKeyValueStoreKeysExclusive_' -timeout 360m -vet=off
2025/05/13 10:12:57 Initializing Terraform AWS Provider...
--- PASS: TestAccCloudFrontKeyValueStoreKeysExclusive_disappears_KeyValueStore (28.26s)
--- PASS: TestAccCloudFrontKeyValueStoreKeysExclusive_value (35.91s)
--- PASS: TestAccCloudFrontKeyValueStoreKeysExclusive_outOfBandRemoval (36.77s)
--- PASS: TestAccCloudFrontKeyValueStoreKeysExclusive_empty (37.87s)
--- PASS: TestAccCloudFrontKeyValueStoreKeysExclusive_basic (41.17s)
--- PASS: TestAccCloudFrontKeyValueStoreKeysExclusive_outOfBandAddition (43.82s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/cloudfrontkeyvaluestore 49.452s
YakDriver
approved these changes
May 13, 2025
|
Warning This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them. Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed. |
|
Thanks for your contribution, @brittandeyoung! 👍 |
|
This functionality has been released in v5.98.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the new
aws_cloudfrontkeyvaluestore_keys_exclusiveresource which will allow managing all aws_cloudfrontkeyvaluestore_keys in a single resource and optimizing API calls.Relations
Relates #39376
References
Output from Acceptance Testing