Skip to content

New resource: aws_bedrockagent_prompt #42211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
May 14, 2025

Conversation

delamarch3
Copy link
Contributor

Description

This implements the resource for AWS Bedrock Prompt Management.

Relations

Closes #38583

References

AWS - Prompt Management User Guide
awscli - create-prompt

Output from Acceptance Testing

% make testacc TESTS=TestAccBedrockAgentPrompt PKG=bedrockagent

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.8 test ./internal/service/bedrockagent/... -v -count 1 -parallel 20 -run='TestAccBedrockAgentPrompt'  -timeout 360m -vet=off
2025/04/12 10:37:58 Initializing Terraform AWS Provider...
=== RUN   TestAccBedrockAgentPrompt_basic
=== PAUSE TestAccBedrockAgentPrompt_basic
=== RUN   TestAccBedrockAgentPrompt_withEncryption
=== PAUSE TestAccBedrockAgentPrompt_withEncryption
=== RUN   TestAccBedrockAgentPrompt_variants
=== PAUSE TestAccBedrockAgentPrompt_variants
=== RUN   TestAccBedrockAgentPrompt_extraFields
=== PAUSE TestAccBedrockAgentPrompt_extraFields
=== RUN   TestAccBedrockAgentPrompt_disappears
=== PAUSE TestAccBedrockAgentPrompt_disappears
=== RUN   TestAccBedrockAgentPrompt_tags
=== PAUSE TestAccBedrockAgentPrompt_tags
=== CONT  TestAccBedrockAgentPrompt_basic
=== CONT  TestAccBedrockAgentPrompt_extraFields
=== CONT  TestAccBedrockAgentPrompt_variants
=== CONT  TestAccBedrockAgentPrompt_withEncryption
=== CONT  TestAccBedrockAgentPrompt_disappears
=== CONT  TestAccBedrockAgentPrompt_tags
--- PASS: TestAccBedrockAgentPrompt_disappears (7.98s)
--- PASS: TestAccBedrockAgentPrompt_basic (9.25s)
--- PASS: TestAccBedrockAgentPrompt_variants (9.33s)
--- PASS: TestAccBedrockAgentPrompt_withEncryption (9.69s)
--- PASS: TestAccBedrockAgentPrompt_tags (20.88s)
--- PASS: TestAccBedrockAgentPrompt_extraFields (28.14s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/bedrockagent       31.840s

@delamarch3 delamarch3 requested a review from a team as a code owner April 12, 2025 09:41
Copy link

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/bedrockagent Issues and PRs that pertain to the bedrockagent service. size/XL Managed by automation to categorize the size of a PR. labels Apr 12, 2025
@ewbankkit ewbankkit added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 13, 2025
@ewbankkit ewbankkit self-assigned this May 13, 2025
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 13, 2025
ewbankkit
ewbankkit previously approved these changes May 13, 2025
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccBedrockAgentPrompt_' PKG=bedrockagent ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.8 test ./internal/service/bedrockagent/... -v -count 1 -parallel 3  -run=TestAccBedrockAgentPrompt_ -timeout 360m -vet=off
2025/05/13 16:29:59 Initializing Terraform AWS Provider...
=== RUN   TestAccBedrockAgentPrompt_basic
=== PAUSE TestAccBedrockAgentPrompt_basic
=== RUN   TestAccBedrockAgentPrompt_withEncryption
=== PAUSE TestAccBedrockAgentPrompt_withEncryption
=== RUN   TestAccBedrockAgentPrompt_variants
=== PAUSE TestAccBedrockAgentPrompt_variants
=== RUN   TestAccBedrockAgentPrompt_extraFields
=== PAUSE TestAccBedrockAgentPrompt_extraFields
=== RUN   TestAccBedrockAgentPrompt_disappears
=== PAUSE TestAccBedrockAgentPrompt_disappears
=== RUN   TestAccBedrockAgentPrompt_tags
=== PAUSE TestAccBedrockAgentPrompt_tags
=== CONT  TestAccBedrockAgentPrompt_basic
=== CONT  TestAccBedrockAgentPrompt_extraFields
=== CONT  TestAccBedrockAgentPrompt_variants
--- PASS: TestAccBedrockAgentPrompt_variants (11.19s)
=== CONT  TestAccBedrockAgentPrompt_tags
--- PASS: TestAccBedrockAgentPrompt_basic (13.72s)
=== CONT  TestAccBedrockAgentPrompt_disappears
--- PASS: TestAccBedrockAgentPrompt_disappears (10.72s)
=== CONT  TestAccBedrockAgentPrompt_withEncryption
--- PASS: TestAccBedrockAgentPrompt_extraFields (29.00s)
--- PASS: TestAccBedrockAgentPrompt_withEncryption (15.09s)
--- PASS: TestAccBedrockAgentPrompt_tags (31.63s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/bedrockagent	48.924s

@ewbankkit
Copy link
Contributor

@delamarch3 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 88119e1 into hashicorp:main May 14, 2025
45 checks passed
Copy link

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.98.0 milestone May 14, 2025
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 16, 2025
Copy link

This functionality has been released in v5.98.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. service/bedrockagent Issues and PRs that pertain to the bedrockagent service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Resource]: aws_bedrockagent_prompt
3 participants