Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_route53_resolver_rule enhancement: new argument server_name_indication to target_ip block #40127

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

alexbacchin
Copy link
Contributor

Description

This PR adds the argument server_name_indication attribute to the target_ip block. It also adds an additional test for this argument.

Relations

Closes #40121

References

Output from Acceptance Testing

% make testacc TESTS=TestAccRoute53ResolverRule_forwardMultiProtocol PKG=route53resolver
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/route53resolver/... -v -count 1 -parallel 20 -run='TestAccRoute53ResolverRule_forwardMultiProtocol'  -timeout 360m
2024/11/14 22:10:53 Initializing Terraform AWS Provider...
=== RUN   TestAccRoute53ResolverRule_forwardMultiProtocol
=== PAUSE TestAccRoute53ResolverRule_forwardMultiProtocol
=== CONT  TestAccRoute53ResolverRule_forwardMultiProtocol
--- PASS: TestAccRoute53ResolverRule_forwardMultiProtocol (317.50s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53resolver    317.583s

...

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/route53resolver Issues and PRs that pertain to the route53resolver service. labels Nov 14, 2024
@alexbacchin alexbacchin changed the title r/aws_route53_resolver_rule enhancement: argument server_name_indication to target_ip block r/aws_route53_resolver_rule enhancement: new argument server_name_indication to target_ip block Nov 14, 2024
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Nov 14, 2024
@alexbacchin alexbacchin marked this pull request as ready for review November 14, 2024 11:58
@alexbacchin alexbacchin requested a review from a team as a code owner November 14, 2024 11:58
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/route53resolver Issues and PRs that pertain to the route53resolver service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: aws_route53_resolver_rule
2 participants